[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-9345) AS7: remove unneeded additional indirection in service usage

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614745#comment-12614745 ] 

Andre Dietisheim commented on JBIDE-9345:
-----------------------------------------

this is not related to lib separation. This issue is about an implementation detail. there is an unneeded additional indirection when accessing the as7 service which is not needed. This was initially provided to be able to deliver 2 different services:

* a 'typed' management service with methods for the different actions (stop, start etc.)
* a 'detyped' management service which would allow the user programmer to send commands directly

First, the 2 different service should have been exposed by different services (and not by a single service which would then deliver 2 different API instances). Second the 'detyped' service is something which we still dont know how we would offer that without exposing the user programmer the as7 jars (which we dont want to)

> AS7: remove unneeded additional indirection in service usage
> ------------------------------------------------------------
>
>                 Key: JBIDE-9345
>                 URL: https://issues.jboss.org/browse/JBIDE-9345
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: JBossAS
>    Affects Versions: 3.3.0.M3
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 3.3.x
>
>
> AS tooling uses an osgi service to interact with the as7 server. This service is implemented in AS7Manager. This manager is not directly exposed but there's an additional indirection to it: JBoss7ManagerService. JBoss7ManagerService basically only instantiates AS7Manager and calls the appropriate method on it. This was initially done because we thought about offerding additional functionalities which did not work out. We should now remove this additional indirection/wrapping since there's no sense to it, it only makes code harder to read.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira