[jbosstools-issues] [JBoss JIRA] Created: (JBIDE-9358) PollThread: separate alerting behaviour from alerting event log

[Andre Dietisheim (JIRA)]

PollThread: separate alerting behaviour from alerting event log
---------------------------------------------------------------

                 Key: JBIDE-9358
                 URL: https://issues.jboss.org/browse/JBIDE-9358
             Project: Tools (JBoss Tools)
          Issue Type: Enhancement
          Components: JBossAS
    Affects Versions: 3.3.0.M3
            Reporter: Andre Dietisheim
            Assignee: Andre Dietisheim
             Fix For: 3.3.0.M3


The current impl of PollThread does inform the event log in a method that does alert the server behavior of the outcome of the polling ( if(finalAlert) ... ) in #alertBehavior:

{code}
	protected void alertBehavior(boolean currentState, boolean finalAlert) {
		if (currentState != expectedState) {
			// it didnt work... cancel all processes! force stop
			behavior.stop(true);
			if (finalAlert)
				alertEventLogFailure();
		} else {
			if (currentState == IServerStatePoller.SERVER_UP)
				behavior.setServerStarted();
			else 
				behavior.stop(true);

			if (finalAlert)
				alertEventLogSuccess(currentState);
		}
	}

{code}

This shall be separated into into its own method.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira