[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606910#comment-12606910 ] 

Max Rydahl Andersen commented on JBIDE-8801:
--------------------------------------------

looking at patch.

Shouldn't:
if(!isNewProjectWizard())
+			model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, false);

just be replaced with:
model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, !isNewProjectWizard());

?

Shouldn't all instances of model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be refactored into
a method call aka shouldCopySeamRuntimeLibraries() or similar ?

isNewProjectWizard does not seem to consider the case where the facet delegate is run from the dynamic web project? Should it ? or is that considered a case where it shouldn't copy libraries too ?



> Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-8801
>                 URL: https://issues.jboss.org/browse/JBIDE-8801
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Seam
>            Reporter: Daniel Azarov
>            Assignee: Max Rydahl Andersen
>             Fix For: 3.3.0.M2
>
>         Attachments: JBIDE-8801.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira