[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8490) top down ws impl class contains wrong value for WebService.serviceName

[Feng Qian (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588539#comment-12588539 ] 

Feng Qian commented on JBIDE-8490:
----------------------------------

For now, a impl class is created for every port type , not for every service. In the example.wsdl, every service has two ports, every port uses one port type. We prefer to use one port for every service.  
So we will have three choices for now:
1 keep the current solution, don't use a service that contains two ports in it. Only fix the 'wrong value' of service name issue.
2 make a big change, make sure we generate a impl for a service, not a porttype. It can fix this issue as a whole, but it is a complex feature.
3 add a choice box in ws dialog, let user to choose a service to generate. Then only generate these impls for the port types that are include by the service (the wtp cxf ws use it)

I prefer to the third choice.
Any comment?

> top down ws impl class contains wrong value for WebService.serviceName
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-8490
>                 URL: https://issues.jboss.org/browse/JBIDE-8490
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Webservices
>    Affects Versions: 3.2.0.Final
>            Reporter: Lukas Jungmann
>            Assignee: Feng Qian
>             Fix For: 3.3.x
>
>         Attachments: example.wsdl
>
>   Original Estimate: 0 minutes
>  Remaining Estimate: 0 minutes
>
> -have attached wsdl - it defines 4 (basic with 2 ports, extra with 2 ports, square with 1 port and square12 with 1 port) services
> -create a web service from it
> =>
> actual: all generated web service impl classes have serviceName attribute of @WebService set to "square"
> expected: serviceName attribute of @WebService set to
>  - "square" in SquarePortTypeImpl
>  - "basic" in AddPortTypeImpl and MinusPortTypeImpl
>  - "extra" in DividerPortTypeImpl and MultiplyPortTypeImpl

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira