[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8490) top down ws impl class contains wrong value for WebService.serviceName

[Lukas Jungmann (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588545#comment-12588545 ] 

Lukas Jungmann commented on JBIDE-8490:
---------------------------------------

re opt 1 - seems to be the simplest solution
re opt 2 - sounds too complicated to me
re opt 3 - best option I think and something I'd like to suggest

draft version of the UI for the jbossws panel in wtp's new top-down ws wizard I have in my head looks like:

+---------------------------------------------------------------+
|  New Web Service                                              |
+---------------------------------------------------------------+
|  JBoss Web Service Code Generation Configuration              |
|     <space for info/error messages>                           |
+---------------------------------------------------------------+
|                                                               |
|  WSDL Service:       |______________________v_|               |
|                                                               |
|  Source folder:      |________________________| [ Browse... ] |
|  Package:            |________________________| [ Browse... ] |
|  Name:               |________________________|               |
|                                                               |
|  Web Service name:   |________________________|               |
|  Web Service URL:    |________________________|               |
|                                                               |
|                                                               |
|                                                               |
|  Artifacts package:  |________________________| [ Browse... ] |
|  JAX-WS version:     |______________________v_|               |
|  Catalog file:       |________________________| [   Add...  ] |
|  Binding files:      |________________________| [   Add...  ] |
|                                                               |
|  Additional options: |________________________| [  Help...  ] |
|                                                               |
|                                                               |
+---------------------------------------------------------------+
|          [  < Back  ] [  Next >  ] [  Cancel  ] [   Finish  ] |
+---------------------------------------------------------------+

where:
WSDL Service combobox - contains list of services/ports available in the wsdl ie in the form of "service#port"
Source folder text field - contains project java source root (could be omitted now and added in the next iteration)
Package and Name text fields - pkg/name of to be created web service implementation class
Web Service name and URL text fields - values for mandatory entries in deployment descriptor (web.xml)
Artifacts package text field - package for artifacts generated by wsconsume (-p option), if any
JAX-WS version combo box - list of JAX-WS target version supported by particular JBossWS runtime
Catalog and Binding files text fields - other options for wsconsume (binding files text field would contain list of files separated by space or ",")
Additional options text field - for forward/backward compatibility, ie in JBossAS 6 there's new option "--additionalHeaders" which user/developer may want to set in some cases, this way we allow it for now and for other newly introduced options in the future without changing the UI
Help button - runs "wsconsume.{sh|bat} -h" and shows filtered(?) output in some dialog so user can check what additional options he can pass to wsconsume

opinions?

> top down ws impl class contains wrong value for WebService.serviceName
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-8490
>                 URL: https://issues.jboss.org/browse/JBIDE-8490
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Webservices
>    Affects Versions: 3.2.0.Final
>            Reporter: Lukas Jungmann
>            Assignee: Feng Qian
>             Fix For: 3.3.x
>
>         Attachments: example.wsdl
>
>   Original Estimate: 0 minutes
>  Remaining Estimate: 0 minutes
>
> -have attached wsdl - it defines 4 (basic with 2 ports, extra with 2 ports, square with 1 port and square12 with 1 port) services
> -create a web service from it
> =>
> actual: all generated web service impl classes have serviceName attribute of @WebService set to "square"
> expected: serviceName attribute of @WebService set to
>  - "square" in SquarePortTypeImpl
>  - "basic" in AddPortTypeImpl and MinusPortTypeImpl
>  - "extra" in DividerPortTypeImpl and MultiplyPortTypeImpl

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira