[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8490) top down ws impl class contains wrong value for WebService.serviceName

[Feng Qian (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604563#comment-12604563 ] 

Feng Qian commented on JBIDE-8490:
----------------------------------

Lukas, 
Based on your draft, there are some problems:
Name text fields:  there are more than one implementation class because a wsdl service will have multi-ports, so the tools will generate multi porttype classes. I think we should remove the Name text, and generate implementation classes using the name: porttype class name + 'Impl' (cxf does it like this)

Pakcage and Artifacts package: I think we should merge the two text into one(Package as now), then put generated Artifacts files into the Package, and put the implementation classes into the PackageName.impl. For example: org.eclipse.ws and or.eclipse.ws.impl

Web Service name and URL text fields: as the upper said, we will generate multi implementation classes, so we will have multi web service name, so we can't make user input the multi web service name easily. I think we should remove these two text fields.


> top down ws impl class contains wrong value for WebService.serviceName
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-8490
>                 URL: https://issues.jboss.org/browse/JBIDE-8490
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Webservices
>    Affects Versions: 3.2.0.Final
>            Reporter: Lukas Jungmann
>            Assignee: Feng Qian
>             Fix For: 3.3.x
>
>         Attachments: example.wsdl
>
>   Original Estimate: 0 minutes
>  Remaining Estimate: 0 minutes
>
> -have attached wsdl - it defines 4 (basic with 2 ports, extra with 2 ports, square with 1 port and square12 with 1 port) services
> -create a web service from it
> =>
> actual: all generated web service impl classes have serviceName attribute of @WebService set to "square"
> expected: serviceName attribute of @WebService set to
>  - "square" in SquarePortTypeImpl
>  - "basic" in AddPortTypeImpl and MinusPortTypeImpl
>  - "extra" in DividerPortTypeImpl and MultiplyPortTypeImpl

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira