[jbosstools-issues] [JBoss JIRA] (JBIDE-10089) Remove updating <style> tag from VpeVisualDomBuilder.updateElement(Node sourceNode) method

Denis Maliarevich (Commented) (JIRA) jira-events at lists.jboss.org
Thu Nov 3 07:06:45 EDT 2011


    [ https://issues.jboss.org/browse/JBIDE-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639623#comment-12639623 ] 

Denis Maliarevich commented on JBIDE-10089:
-------------------------------------------

<style> is updated in a special way: there is no need in removing and adding its visual node.
Thus the update statement is reasonable in that place.
                
> Remove updating <style> tag from VpeVisualDomBuilder.updateElement(Node sourceNode) method
> ------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-10089
>                 URL: https://issues.jboss.org/browse/JBIDE-10089
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor Templates
>    Affects Versions: 3.3.0.M4
>            Reporter: Denis Maliarevich
>            Assignee: Denis Maliarevich
>            Priority: Optional
>             Fix For: 3.3.0.Beta1
>
>
> There is a bad way of updating <style> tag in updateElement(Node sourceNode) method:
> {code}
> /*
> * special processing of "style" element
> * 
> * for unification of updating nodes - or redevelop updating
> * mechanism (for example : transfer this function to template )
> * or redevelop template of "style" element
> */
> if (HTML.TAG_STYLE.equalsIgnoreCase(sourceNode.getNodeName())) {
> 	// refresh style node
> 	VpeStyleUtil.refreshStyleElement(this, elementMapping);
> 	return;
> }
> {code}
> Should be removed to the style template.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list