[jbosstools-issues] [JBoss JIRA] (JBIDE-9940) Quickfix and Wizard for fixing ambigious injection warning is confusing

[Daniel Azarov (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641528#comment-12641528 ] 

Daniel Azarov commented on JBIDE-9940:
--------------------------------------

fixed, updated messages

last screen shot:

!SpecifyCDIBean3.png!
                
> Quickfix and Wizard for fixing ambigious injection warning is confusing
> -----------------------------------------------------------------------
>
>                 Key: JBIDE-9940
>                 URL: https://issues.jboss.org/browse/JBIDE-9940
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: CDI
>            Reporter: Max Rydahl Andersen
>            Assignee: Daniel Azarov
>            Priority: Blocker
>             Fix For: 3.3.0.Beta1
>
>         Attachments: addremovequalifiers.png, quickfix_specify_bean_for_injection.png, SpecifyCDIBean.png, SpecifyCDIBean3.png, SpecifyCDIBeanForInjectionPoint1.png, SpecifyCDIBeanForInjectionPoint2.png, SpecifyCDIBeanForInjectionPoint3.png, SpecifyCDIBeanNew.png
>
>
> Tried to use the quickfix for fixing ambigious injection points - it is *very* confusing.
> I use the jboss-javaee6-webapp quickstart from Central and I get a warning about ambigous injection (which is true since there are two on the classpath)
> I get this when trying to quickfix it:
> !quickfix_specify_bean_for_injection.png!
> The message reads "Specify <some injection source> bean for injection to injection point".
> That sounds to me like when I press this it will figure out which qualifiers that is to be set on this to make it choose this.
> When I choose one of these it give me this wizard:
> !addremovequalifiers.png!
> And now my confusion starts:
> 1) Its not clear what "Bean" it is referring to - it is written in the long text label but that is not the first thing you look at - this should be more clear.
> 2) Its error is saying "This set of qualifiers is not unique" immediately - but it doesn't say which beans its actually matching so you don't really know what kind of "uniqueness" that is the problem. 
>  Maybe we should write something like "We could not find a set of qualifiers that makes the LoggerProducer.produceLog() unique for @Injection Logger log. You can make it unique by changing the  qualifiers below"
> 3) Using Create Qualifier I actually get a new qualifier showing up in the editor behind the wizard but it does not show up in available list of qualifiers and now a completely different qualifier have been added to Available section.
> 4) When I actually do add qualifiers and pres Finish - there is no warning or information about what actually will change; I would expect a preview dialog for this especially since we are actually changing the Bean source and not the injection point we are coming from.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira