[jbosstools-issues] [JBoss JIRA] (JBIDE-10137) Close input and output stream in all places where it used

[Alexey Kazakov (Updated) (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Kazakov updated JBIDE-10137:
-----------------------------------

    Fix Version/s: 3.3.x
                       (was: 3.3.0.Beta1)


I fixed a couple of places where we should close streams. But most cases you mentioned belong to the dead code (I removed some dead code but we still have some). Also you mentioned code (for example XHTMLValidator) which creates input streams but should NOT close it since this code returns the open streams which will be used by clients.
                
> Close input and output stream in all places where it used
> ---------------------------------------------------------
>
>                 Key: JBIDE-10137
>                 URL: https://issues.jboss.org/browse/JBIDE-10137
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: common/jst/core, jsp/jsf/xml source editing
>    Affects Versions: 3.3.0.M4
>            Reporter: Vitali Yemialyanchyk
>            Assignee: Alexey Kazakov
>            Priority: Trivial
>             Fix For: 3.3.x
>
>
> Unfortunately I've find a lot of places in JBossTools where InputStream & OutputStream are used and are not closed. Just make a search and inspect all over the code.
> Here just list of places for org.jboss.tools.jsf plugin:
> 1) JSF2ComponentModelManager -> public static IDOMDocument getReadableDOMDocument(JarEntryFile file) 
> 2) JSF2Util -> public static String readManifest(IProject project, String jarName) throws CoreException, IOException
> 3) JSF2TemplateManager -> public InputStream createStreamFromTemplate(String templateName)
> 4) JSF2ComponentsValidator -> protected boolean isValidate(IFile file)
> 5) XHTMLEntityResolver -> public static XMLInputSource _internalResolveEntity(... -> is.setByteStream(new LazyURLInputStream(physical));
> 6) XHTMLValidator -> stream = new FilteredInputStream(connect.getInputStream());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira