[jbosstools-issues] [JBoss JIRA] (JBIDE-10016) NullPointerException in VPE when an attribute is intensively changed

[Denis Golovin (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645779#comment-12645779 ] 

Denis Golovin commented on JBIDE-10016:
---------------------------------------

mixing refactoring (two classes moved out) with bug fixing makes it really difficult to review, so if you really want to make  it into trunk you have to ether avoid refactoring or provide two incremental patches, one with refactoring and second with fix.

I have reviewed first patch and found it good to be applied, because it seems to fix issue with interruption of UI job and makes update faster.

Didn't have time to review the second, but I see it has "optimization", which is counting the events and just switch to full refresh if more than 30 events happened. I'll review it later today or Monday. 

I need a JUnit test to test "optimization" in your last fix and that last thing we need to get it applied into trunk.





                
> NullPointerException in VPE when an attribute is intensively changed
> --------------------------------------------------------------------
>
>                 Key: JBIDE-10016
>                 URL: https://issues.jboss.org/browse/JBIDE-10016
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>            Reporter: Yahor Radtsevich
>            Assignee: Yahor Radtsevich
>             Fix For: 3.3.0.M5
>
>         Attachments: JBIDE-10016_20111025.patch, JBIDE-10016_20111125.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira