[jbosstools-issues] [JBoss JIRA] (JBDS-1939) Installer thrashes disk looking for desktop file it didn't create

[Nick Boldt (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646370#comment-12646370 ] 

Nick Boldt edited comment on JBDS-1939 at 11/29/11 11:13 AM:
-------------------------------------------------------------

I think I have this fixed via local build -- checking $HOME/Desktop and install dir will now only happen if user asks to create dekstop shortcut.

Additionally, the find command is restricted to looking for files (not dirs) and only within the single folder (not its children) `-maxdepth 1 -mindepth 1 -type f`:

{code}
if (isUnixLikeSystem() && !OsVersion.IS_OSX && searchDesktop)
        {
                        String name = idata.getVariable("DESKTOP_SHORTCUT_NAME");
                        StringBuffer cmd = new StringBuffer();
                        // if checkbox to create additional desktop shortcut was selected, will produce 2 shortcuts: 1 in INSTALL_DIR & 1 in ~/Desktop (or equivalent)
                        cmd.append("find \"" + idata.getVariable("INSTALL_PATH") + "\"" + " \"" + getConfiguredDesktopLocation() + "\"" + " -maxdepth 1 -mindepth 1 -type f -name \"" + name + "*.desktop\" -exec chmod +x {} \\;");
                        try {
                                Debug.log("Running script: `" + cmd + "` ...");
                                ShellScript.execute(cmd, File.createTempFile("jbds-chmod-", ".sh").getAbsolutePath());
...
{code}


Can you test with the latest JBDS nightly build? 

http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk.product/builds/nightly/trunk/latestBuild.html
                
      was (Author: nickboldt):
    I think I have this fixed via local build. 

Can you test with the latest JBDS nightly build? 

http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk.product/builds/nightly/trunk/latestBuild.html
                  
> Installer thrashes disk looking for desktop file it didn't create
> -----------------------------------------------------------------
>
>                 Key: JBDS-1939
>                 URL: https://issues.jboss.org/browse/JBDS-1939
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: installer
>    Affects Versions: 4.0.0.GA, 5.0.0.M3
>         Environment: Linux (Fedora 16)
>            Reporter: James Livingston
>            Assignee: Nick Boldt
>             Fix For: 5.0.0.M5
>
>
> When installing JBDS, you are given the option of creating a "Start Menu" entry for it.
> On Linux at least, if you uncheck that box and press Next it runs a script (/tmp/jdbs-desktop-chmod-$RANDOM.sh) which executes "find $HOME -name JBoss-Developer-Studio-5.0.0.M4*.desktop". My desktop has appromiately 1.6 million files under $HOME, and that step thrashes my disk for 10 minutes.
> I'm not sure why it is trying to find the desktop file since I chose not to create one. In addition, searching my entire home directory for it is not a good idea since it could take a very long time.
> Is there a reason it is looking for a .desktop file when I told it not to create one? It should already know where it is if it created one, and there is unlikely to be one if it didn't.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira