[jbosstools-issues] [JBoss JIRA] (JBIDE-9932) Fix VpeDomMapping.getNodeMappingAtVisualNode to use HashMap.get instead of iteration

[Denis Maliarevich (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646620#comment-12646620 ] 

Denis Maliarevich edited comment on JBIDE-9932 at 11/30/11 7:29 AM:
--------------------------------------------------------------------

1) Adding the new visual node to visualContainer is performed in VpeVisualDomBuilder.addNode(..) method. Only after this operation VpeDomMapping should be registered with this brandNewNode.
2) Some important information for creating VpeDomMapping could be obtained only inside  VpeVisualDomBuilder.createNode(..) method.
3) Based on the notes above -- the solution is to return VpeDomMapping from VpeVisualDomBuilder.createNode(..) method.

                
      was (Author: dmaliarevich):
    1) Adding the new visual node to visualContainer is performed in VpeVisualDomBuilder.addNode(..) method. Only after this node is added VpeDomMapping should be registered with this brandNewNode.
2) Some important information for creating VpeDomMapping could be obtained only inside  VpeVisualDomBuilder.createNode(..) method.
3) Based on the notes above -- the solution is to return VpeDomMapping from VpeVisualDomBuilder.createNode(..) method.

                  
> Fix VpeDomMapping.getNodeMappingAtVisualNode to use HashMap.get instead of iteration
> ------------------------------------------------------------------------------------
>
>                 Key: JBIDE-9932
>                 URL: https://issues.jboss.org/browse/JBIDE-9932
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>    Affects Versions: 3.3.0.M4
>            Reporter: Denis Golovin
>            Assignee: Denis Maliarevich
>             Fix For: 3.3.0.M5
>
>
> nsIDOMNode.appendChild(nsIDOMNode child) actually adds copy of child provided and returns it as result. VPE saves in map a child passed as parameter instead of actually added node returned from appendChild method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira