[jbosstools-issues] [JBoss JIRA] (JBIDE-9845) Unify publish / behaviour / launch APIs for AS/Servers

[Andre Dietisheim (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632487#comment-12632487 ] 

Andre Dietisheim edited comment on JBIDE-9845 at 10/5/11 10:16 AM:
-------------------------------------------------------------------

EgitPublishMethod is not compiling any more. It complains about the method #getPublishMethodType which is commented now in IJBossServerPublishMethod. I commented the method in EgitPublishMethod and added the extension:

{code}
      <extension
         point="org.jboss.ide.eclipse.as.core.behaviourExtension">
      <behaviour
            behaviourDelegate="org.jboss.ide.eclipse.as.egit.core.EgitBehaviourDelegate"
            name="%EGitMethodName"
            publishMethod="org.jboss.ide.eclipse.as.egit.core.EgitPublishMethod"
            serverTypes="%ServerTypesJBoss7"
            typeId="egit">
      </behaviour>
   </extension>
{code}

launchDelegate is optional in the extension scheme so I left it blank since we have no launch delegate for egit. 

@Rob: please review

                
      was (Author: adietish):
    EgitPublishMethod is not compiling any more. It complains about the method #getPublishMethodType which is commented now in IJBossServerPublishMethod. I commented the method in EgitPublishMethod and added the extension:

{code}
     <extension
         point="org.jboss.ide.eclipse.as.core.behaviourExtension">
      <behaviour
            behaviourDelegate="org.jboss.ide.eclipse.as.egit.core.EgitBehaviourDelegate"
            name="%EGitMethodName"
            publishMethod="org.jboss.ide.eclipse.as.rse.core.RSEPublishMethod"
            serverTypes="%ServerTypesJBoss7"
            typeId="egit">
      </behaviour>
   </extension>
{code}

launchDelegate is optional in the extension scheme so I left it blank since we have no launch delegate for egit. 

@Rob: please review

                  
> Unify publish / behaviour / launch APIs for AS/Servers
> ------------------------------------------------------
>
>                 Key: JBIDE-9845
>                 URL: https://issues.jboss.org/browse/JBIDE-9845
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.M3
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 3.3.0.M4
>
>
> The APIs for these things are not unified, spread through manual class calls and extension points. This needs to be collected in preparation for adding a third behaviour type. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira