[jbosstools-issues] [JBoss JIRA] (JBIDE-9837) Requirements weirdness for project examples

[Max Rydahl Andersen (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634320#comment-12634320 ] 

Max Rydahl Andersen commented on JBIDE-9837:
--------------------------------------------


>We are defining required runtimes (servers)/plugins within a project example file.
>For instance, as to the JBoss AS 7 helloworld example there are the following requirements >(http://download.jboss.org/jbosstools/examples/project-examples-maven-3.3.xml):

><fixes>
><fix type="wtpruntime">
><property name="allowed-types">org.jboss.ide.eclipse.as.runtime.70</property>
><property name="description">This project example requires JBoss AS 7.0</property>
><property name="downloadId">org.jboss.tools.runtime.core.as.701</property>
></fix>

I get this - so what happens when there are multiple allowed server types? will it provide an install button for all?

>If you don't have any JBoss AS 7 server downloaded, you can select the Download and Install button that will download and >install JBoss AS 7.0.1 
>(<property name="downloadId">org.jboss.tools.runtime.core.as.701</property>).

and here - what happens if multiple options ? 

>You can choose the Install button that will automatically install these features using the Mylyn discovery engine or you can >choose the Install New Software button that will call the P2 Install dialog. The last option is intended for advanced users.

for this to work these would need to be listed in the mylyn discovery sites, correct ? For M4 we don't have these so better to disable that for now I assume ?

>When starting the "Run and deploy the application" action
>you will get the standard WTP "Run On Server" dialog
>so that you can decide what server to use to deploy and run the application (as well as the Arquillian test).

Except when you deleted the server - then there is the runtime left and there is nothing to actually deploy to.

> if I have 1 or more servers it shows nothing. No options for downloading another server nor say which server it will choose.
> That means that the user's environment contains all necessary requirements to run the tutorial.

>> Ok - for me it still just says "This project example requires JBoss AS"

>>What project example? I couldn't find that message in any project example xml file. Could you create a screenshot? It is >>possible that there is a problem with layout on Mac if you use it.

!screenshot0.png!

> and only when have zero servers.

>>If there are all required servers/plugins, there is no message. If you, for instance, try to add JBoss AS 6, 5 or 4, but not >>JBoss AS 7, the message "This project example requires JBoss AS 7.0" will be written when starting some JBoss AS 7 Quickstarts >>example because they require JBoss AS 7.

it only seem to check for runtime existence, not server existence.

>> The org.jboss.tools.runtime.core.as.701 extension point is defined in the o.j.t.runtime.core plugin.
>> >He can also call the Runtime Detection Preferences page and install whatever runtime he wants (JBoss AS 7.0.0, 7.0.1 or 7.0.2).

> I don't see that in the build from today yet.

>Currently, the user can set runtimes that are downloaded and unpacked . I haven't implemented the Download button in the Runtime >Detection Preferences page. Will do it ASAP.

yeah - even if I got a server type configured as AS7 I would still like to easily be able to download these runtimes without having to delete all servers.

>> The download went in the background, I pressed run and it seemed to import/create the projects still - shouldn't it wait for >>the download to complete and then show a dialog about what will happen ?

>Do you want me to remove the Run in Background button. Suppose we could leave the Cancel button because the download could take >a long time.

It's okey - I now understand that "Run" doesn't mean run but "Start" :)

I would say if the requirement is still not downloaded and configured clicking Start should show a dialog asking something like:

"<list of requirements> which is required for this example is still downloading. Do you still want to start the example ? Yes|No"

  
                
> Requirements weirdness for project examples
> -------------------------------------------
>
>                 Key: JBIDE-9837
>                 URL: https://issues.jboss.org/browse/JBIDE-9837
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central, project-examples
>            Reporter: Max Rydahl Andersen
>            Assignee: Snjezana Peco
>            Priority: Critical
>             Fix For: 3.3.0.M4
>
>         Attachments: jbosscentrala.png, jbosscentralb.png, jbosscentralc.png, jbosscentrald.png, screenshot0.png
>
>
> The new ui for project examples with respect to "install"/download and install and requirements is behaving weird:
> 1) The requirement section is empty if the requirements exist - so users can't actually see what it will use
> 2) it says "This example needs JBoss AS" but doesn't say anything about version or where it will get the server from when asking for installation dir.
>     Should at least say which version is needed, what it is downloading.
> 3) Pressing download & Install, answering all the questions a  dialog box comes up showing download, which I then can put in backgroun (nice) - but now the Run button is there, I click on it and nothing happens.
> 4) If I got all requirements and press "Run" it still doesn't do anything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira