[jbosstools-issues] [JBoss JIRA] (JBIDE-9947) New Openshift project - runtime validation

[Andre Dietisheim (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635892#comment-12635892 ] 

Andre Dietisheim edited comment on JBIDE-9947 at 10/20/11 2:37 AM:
-------------------------------------------------------------------

attached a patch, need intense checking.

Basically the problem here is that we validate on behalf of several properties:

- "create adapter" checkbox
- "available runtimes" items in the combo
- "selected runtime" selected combo item

!validate-runtime.png!

To solve this with databinding we do not add validators to bindings. Validators in bindings are only able to validate single values (not composite properties). In databinding we add a MultiValidator to the DataBindingContext. The only tricky part is that you have to access all values, that take part in the the validation result, on behalf of observable values (and not in widgets/beans). The MultiValidator tracks behind the scene what observables are accessed and elaborates when he has to revalidate instead of returning a cached value. If your validator impl accesses the validation values in widgets (not observables), then the validator wont be called when the values, that participate in the validation, change.  
                
      was (Author: adietish):
    attached a patch, need intense checking.

Basically the problem here is that we validate on behalf of several properties:

- "create adapter" combo
- "available runtimes"
- "selected runtime"

!validate-runtime.png!

To solve this with databinding we do not add validators to bindings. Validators in bindings are only able to validate single values (not composite properties). In databinding we add a MultiValidator to the DataBindingContext. The only tricky part is that you have to access all values, that take part in the the validation result, on behalf of observable values (and not in widgets/beans). The MultiValidator tracks behind the scene what observables are accessed and elaborates when he has to revalidate instead of returning a cached value. If your validator impl accesses the validation values in widgets (not observables), then the validator wont be called when the values, that participate in the validation, change.  
                  
> New Openshift project - runtime validation
> ------------------------------------------
>
>                 Key: JBIDE-9947
>                 URL: https://issues.jboss.org/browse/JBIDE-9947
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.M4
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 3.3.0.Beta1
>
>         Attachments: validate-runtime.patch, validate-runtime.png
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira