[jbosstools-issues] [JBoss JIRA] (JBIDE-10001) NPE when saying no to not publishing

[Max Rydahl Andersen (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636608#comment-12636608 ] 

Max Rydahl Andersen commented on JBIDE-10001:
---------------------------------------------

seem to be a very stupid and weirdly non-found arrary index bug.

Patch is:

Index: ExpressPublishMethod.java
===================================================================
                
> NPE when saying no to not publishing
> ------------------------------------
>
>                 Key: JBIDE-10001
>                 URL: https://issues.jboss.org/browse/JBIDE-10001
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.M4
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.3.0.M4, 3.3.0.Beta1
>
>
> Said no to a server which might not have all its modules and got these errors:
> java.lang.NullPointerException
> 	at org.eclipse.egit.core.IteratorService.createInitialIterator(IteratorService.java:39)
> 	at org.jboss.ide.eclipse.as.egit.core.EGitUtils.countCommitableChanges(EGitUtils.java:459)
> 	at org.jboss.tools.openshift.express.internal.core.behaviour.ExpressPublishMethod.publishModule(ExpressPublishMethod.java:46)
> 	at org.jboss.ide.eclipse.as.core.server.internal.DeployableServerBehavior.publishModule(DeployableServerBehavior.java:92)
> 	at org.jboss.ide.eclipse.as.core.server.internal.v7.DelegatingJBoss7ServerBehavior.publishModule(DelegatingJBoss7ServerBehavior.java:84)
> 	at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModule(ServerBehaviourDelegate.java:1046)
> 	at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModules(ServerBehaviourDelegate.java:1138)
> 	at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:955)
> 	at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:774)
> 	at org.eclipse.wst.server.core.internal.Server.publishImpl(Server.java:3027)
> 	at org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:341)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> missing null check somewhere ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira