[jbosstools-issues] [JBoss JIRA] Issue Comment Edited: (JBIDE-9747) Possibility of update node instead of recreating has been removed in VPE templates

[Yahor Radtsevich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629334#comment-12629334 ] 

Yahor Radtsevich edited comment on JBIDE-9747 at 9/20/11 7:30 AM:
------------------------------------------------------------------

This possibility has been removed more than 2 years ago [1] under the scope of JBIDE-4110. It was done because it was too hard and error prone to maintain 'create', 'removeAttribute' and 'setAttribute' for each template instead of only 'create' method.

Anyway, usually just one execution of a VpeTemplate.create() method is not time consuming. What is really time consuming is recreation of all children after recreation of the parent.


1. https://source.jboss.org/viewrep/JBossTools/trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java?r1=14354&r2=14623#seg1

      was (Author: yradtsevich):
    This possibility has been removed more than 2 years ago [1] under the scope of JBIDE-4110. It is done because it is too hard and error prone to maintain 'create', 'removeAttribute' and 'setAttribute' for each template instead of only 'create' method.

Anyway, usually just one execution of a VpeTemplate.create() method is not time consuming. What is really time consuming is recreation of all children after recreation of the parent.


1. https://source.jboss.org/viewrep/JBossTools/trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java?r1=14354&r2=14623#seg1
  
> Possibility of update node instead of recreating has been removed in VPE templates
> ----------------------------------------------------------------------------------
>
>                 Key: JBIDE-9747
>                 URL: https://issues.jboss.org/browse/JBIDE-9747
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor Templates
>    Affects Versions: 3.3.0.M2
>            Reporter: Maxim Areshkau
>            Assignee: Yahor Radtsevich
>            Priority: Critical
>
> Possibility of update node instead of recreating has been removed in VPE templates what is reason of performance issues. For example when we update style in some div, it will call rebuild of all div chidren, instead of updating style in visual div. Previously the updating was done via VpeAbstractTemplate.recreateAtAttrChange function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira