[jbosstools-issues] [JBoss JIRA] (JBIDE-11465) Wrong source insertion after dnd an element into the <div /> with no end tag on JSP page.

[Denis Maliarevich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681568#comment-12681568 ] 

Denis Maliarevich commented on JBIDE-11465:
-------------------------------------------

The problem is that method in class 
{code}
org.eclipse.wst.xml.core.internal.document.XMLModelUpdater.replaceChild(Node parentNode, Node newChild, Node oldChild)
{code}
does not generate "postTag" while inserting dragged element into the div which has no children before the drop. 
For xhtml files -- "postTag" is generated.
* * *
There is a condition which adds missing end tag in XMLModelUpdater.replaceChild(..):
{code}
if (element.isEmptyTag()) { // empty tag format
{code}
 -- it gives true for <div /> in xhtml file, and false -- for <div /> in jsp file, it's internal eclipse behavior. So I guess we shuold check/add correct end tag in our own VpeDnDHelper.drop(..) method.
                
> Wrong source insertion after dnd an element into the <div /> with no end tag on JSP page.
> -----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-11465
>                 URL: https://issues.jboss.org/browse/JBIDE-11465
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>    Affects Versions: 3.3.0.Beta2
>            Reporter: Denis Maliarevich
>            Assignee: Denis Maliarevich
>             Fix For: 3.3.0.Beta3
>
>
> After DnD an element into the <div /> with no end tag on JSP page -- it is inserted at the end of the tag, but not inside of it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira