[jbosstools-issues] [JBoss JIRA] (JBIDE-11530) Add Code Field To ValidationStatus Object To Facilitate Successful Test Verification

[Dan Florian (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Florian resolved JBIDE-11530.
---------------------------------

    Release Notes Docs Status: Not Required
                   Resolution: Done


Added a code to ValidationStatus that identifies the status message. Changed tests to verify the expected code is contained in the status.
                
> Add Code Field To ValidationStatus Object To Facilitate Successful Test Verification
> ------------------------------------------------------------------------------------
>
>                 Key: JBIDE-11530
>                 URL: https://issues.jboss.org/browse/JBIDE-11530
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: modeshape
>    Affects Versions: 3.3.0.Beta3
>            Reporter: Dan Florian
>            Assignee: Dan Florian
>             Fix For: 3.3.0.Beta3
>
>
> The CndValidator does not stop validating once an error is found. It is quite possible that validation will find more than one error. The CndValidator tests are checking to make sure the ValidationStatus is an error when an error is expected. However it does not check that the specific error is the one that is expected. So it is quite possible that a test could have a "false positive" result. There needs to be a way to make sure the expected error is contained in the ValidationStatus object. Having a code attached to each status message would be one way to do that. The test could then check to make sure the ValidationStatus contains the expected code. It also might be a good idea to move the validation messages out of CndMessages and iron their own properties file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira