[jbosstools-issues] [JBoss JIRA] (JBIDE-11675) GWT Builder gives NPE in findModules
Max Rydahl Andersen (JIRA)
jira-events at lists.jboss.org
Thu Apr 26 07:17:18 EDT 2012
[ https://issues.jboss.org/browse/JBIDE-11675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12687944#comment-12687944 ]
Max Rydahl Andersen commented on JBIDE-11675:
---------------------------------------------
I've committed a patch for this which simply stops doing anything if no maven config is found.
Please check if ok and resolve if it is.
Index: plugins/org.jboss.tools.maven.gwt/src/org/jboss/tools/maven/gwt/GWTProjectConfigurator.java
===================================================================
--- plugins/org.jboss.tools.maven.gwt/src/org/jboss/tools/maven/gwt/GWTProjectConfigurator.java (revision 40512)
+++ plugins/org.jboss.tools.maven.gwt/src/org/jboss/tools/maven/gwt/GWTProjectConfigurator.java (working copy)
@@ -87,6 +87,11 @@
boolean configureGWT = store.getBoolean(Activator.CONFIGURE_GWT);
if(configureGWT){
Plugin newConfig = event.getMavenProject().getMavenProject().getPlugin(GWT_WAR_MAVEN_PLUGIN_KEY);
+ if(newConfig==null) {
+ // no config found so just stop.
+ return;
+ }
+
IJavaProject javaProject = JavaCore.create(event.getMavenProject().getProject());
List<String> modNames = findModules(newConfig, javaProject);
> GWT Builder gives NPE in findModules
> ------------------------------------
>
> Key: JBIDE-11675
> URL: https://issues.jboss.org/browse/JBIDE-11675
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: GWT
> Reporter: Max Rydahl Andersen
> Assignee: Denis Golovin
> Priority: Critical
> Fix For: 3.3.0.Beta3
>
>
> one of my html5 apps (no gwt in there afaics) is triggering an NPE:
> java.lang.NullPointerException
> at org.jboss.tools.maven.gwt.GWTProjectConfigurator.findModules(GWTProjectConfigurator.java:104)
> at org.jboss.tools.maven.gwt.GWTProjectConfigurator.mavenProjectChanged(GWTProjectConfigurator.java:92)
> at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.mavenProjectChanged(ProjectConfigurationManager.java:752)
> at org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.notifyProjectChangeListeners(ProjectRegistryManager.java:724)
> at org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.applyMutableProjectRegistry(ProjectRegistryManager.java:847)
> at org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:280)
> at org.eclipse.m2e.core.internal.project.registry.MavenProjectManager.refresh(MavenProjectManager.java:58)
> at org.eclipse.m2e.core.internal.builder.MavenBuilder.build(MavenBuilder.java:120)
> at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:728)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:199)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:239)
> at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:292)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:295)
> at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:351)
> at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:374)
> at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:143)
> at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jbosstools-issues
mailing list