[jbosstools-issues] [JBoss JIRA] (JBIDE-12405) As-you-type validation works slow when many strings are being added

Victor Rubezhny (JIRA) jira-events at lists.jboss.org
Fri Aug 10 09:38:06 EDT 2012


    [ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710909#comment-12710909 ] 

Victor Rubezhny commented on JBIDE-12405:
-----------------------------------------

Alexey, I cannot reproduce your last case: at step 6 I see validation problem. 

Regarding the "EL validator shows only first 20 problems by default" - this shouldn't be an option for As-You-Type validation, IMHO. When user changes some text he(she) must be granted to see the problems in the changed part of text. This option (20 problems by default) is good only for builder validation. But, IMHO, it shouldn't play for As-You-Type at all.

The following example shows that when I have inserted two lines (#31 and #32) and strings from these two lines are to be validated... But the As-You-Type validator doesn't report problems for these two lines. It reports me 22 problems for completely other lines. In my opinion it's wrong and not suitable for As-You-Type validation.

{code}
>>> beginProcessing
>>> validateString: 8 regions
Partitions to validate:
	[Line: 32>>>""]
	[Line: 31>>>""]
	[Line: 31>>>"#{test.bytess} sf sdf "]
	[Line: 31>>>""]
	[Line: 32>>>"#{test.bytess} sf sdf "]
	[Line: 32>>>""]
	[Line: 32>>>""]
	[Line: 31>>>""]

Validation Message: 8: Producer method or field cannot be annotated @Inject [JSR-299 §3.3.2, §3.4.2]
Validation Message: 129: "test" cannot be resolved
Validation Message: 76: "test" cannot be resolved
Validation Message: 114: "test" cannot be resolved
Validation Message: 52: "test" cannot be resolved
Validation Message: 158: "test" cannot be resolved
Validation Message: 16: "test" cannot be resolved
Validation Message: 87: "test" cannot be resolved
Validation Message: 41: "test" cannot be resolved
Validation Message: 171: "test" cannot be resolved
Validation Message: 30: "test" cannot be resolved
Validation Message: 56: "test" cannot be resolved
Validation Message: 91: "test" cannot be resolved
Validation Message: 137: "test" cannot be resolved
Validation Message: 110: "test" cannot be resolved
Validation Message: 162: "test" cannot be resolved
Validation Message: 67: "test" cannot be resolved
Validation Message: 34: "test" cannot be resolved
Validation Message: 125: "test" cannot be resolved
Validation Message: 184: "test" cannot be resolved
Validation Message: 80: "test" cannot be resolved
Validation Message: 64: "test" cannot be resolved
<<< validateString
validateJavaElement: 0 regions
<<< endProcessing: 657ms
{code}


                
> As-you-type validation works slow when many strings are being added
> -------------------------------------------------------------------
>
>                 Key: JBIDE-12405
>                 URL: https://issues.jboss.org/browse/JBIDE-12405
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: common/jst/core
>    Affects Versions: 3.4.0.M1
>            Reporter: Alexey Kazakov
>            Assignee: Victor Rubezhny
>            Priority: Blocker
>             Fix For: 3.4.0.M1
>
>
> 1. Create a cdi bean class.
> 2. Add the following lines to any method of the class:
> {code}
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> 			System.out.println("#{test.bytess} sf sdf " + "" + "" + "");
> {code}
> 3. Repeat #2 a ten times.
> 4. There are 0.5n(n+1) as-you-type validation thread created, where n is a nubmer of srings of the file.
> So if you copied a hundred strings you will have 5050 threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       



More information about the jbosstools-issues mailing list