[jbosstools-issues] [JBoss JIRA] (JBIDE-12419) archives core should not have references to NLS class in src/main

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711143#comment-12711143 ] 

Rob Stryker commented on JBIDE-12419:
-------------------------------------

Oddly enough, teh commits that add NLS to the classes was wrong, but it was wrong over 3 years ago (https://source.jboss.org/changelog/JBossTools?cs=14646). 

The unit test does the following when creating the launch path:

			String equinoxJar = FileLocator.getBundleFile(Platform.getBundle("org.eclipse.equinox.common")).getAbsolutePath();
			map.put(ECLIPSE_LOC, eclipseHome);
			map.put(EQUINOX_JAR, equinoxJar);
			map.put(PROJECT_NAME, "SimpleAntTest");
			map.put(ARCHIVES_HOME, RUNTIME_WORKBENCH ? PLUGIN_LOCATION : eclipseHome);
			map.put(PROJECT_DIR, projectLoc.toOSString());

This indicates that org.eclipse.equinox.common is added ot the build path, as well as the archives plugins, and the example project itself. The NLS class lives in org.eclipse.osgi.util.  A search against earlier versions of eclipse does not show the NLS class moving at all, so theoretically, this test should have failed for the past 3 years. Very strange. 
                
> archives core should not have references to NLS class in src/main
> -----------------------------------------------------------------
>
>                 Key: JBIDE-12419
>                 URL: https://issues.jboss.org/browse/JBIDE-12419
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Archives
>    Affects Versions: 3.3.1
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 3.3.2, 3.4.0.M1
>
>
> The old use case to run project archives from cmd line requires a strict set of jars. References to NLS class are not allowed.  Problem can be seen in build unit test SimpleAntTest
> Error Message
> The ant task did not successfully complete.   BUILD FAILED  /mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25: java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS    
> Stacktrace
> junit.framework.AssertionFailedError: The ant task did not successfully complete. 
> BUILD FAILED
> /mnt/hudson_workspace/workspace/jbosstools-3.3_trunk.component--archives/sources/tests/org.jboss.ide.eclipse.archives.test/target/work/data/AntTest/build.xml:25: java.lang.NoClassDefFoundError: org/eclipse/osgi/util/NLS

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira