[jbosstools-issues] [JBoss JIRA] (JBIDE-12189) AS server adapters should check and provide way to fix or enough error info for users to get deployment working

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-12189.
---------------------------------

    Resolution: Rejected


As much as I appreciate the jiras you reference, all three have been solved, and the "framework to report errors" is already in place. In almost all of those cases, the error was the deploy or temp deploy folder not existing. In this case, we could have thrown an exception and refused to publish, or, we could create the folder. 

Currently we create the folders. If you'd prefer we throw a CoreException instead, we can stop auto-creation and simply throw the CoreException to the user. 

The title of this jira is "AS server adapters should check and provide way to fix or enough error info for users to get deployment working".  There are currently no use cases where not enough info is present. If you can find a current use case where not enough information is present for the user to fix their deployment, I would re-consider this issue. 

Is your request that we instead do NOT auto-create the deploy and temp deploy folders and instead throw CoreException? That's the only thing I can see you'd be requesting in this jira. I assume this is not your intent. I assume you think the other 3 issues were actually solved and the users have a seamless experience now. 

I also would not say the issue is that too much is done in UI code. The default folders are *NOT* created in the UI. They are not created as a result of UI either. THey are created once a new server is added. The creation of a new server, whether done in UI or via API, will create the appropriate deploy and temp deploy folders. The poorly-named class "ServerListener" is in charge of this, and is completely unreliant upon the UI or the wizard at all. 

So, to summarize, we already have a framework for reporting errors. In all cases of errors, we have to make a decision whether to fix the problem gracefully or abort and throw an error to the user. In all of your linked examples, we now fix the problem silently. 

As any new issues come up, we will make a similar decision:  fix the problem silently or abort and throw the error. Since the 3 existing issues are already fixed via the silently-fix solution, I can see no reason to keep this issue open
                
> AS server adapters should check and provide way to fix or enough error info for users to get deployment working
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-12189
>                 URL: https://issues.jboss.org/browse/JBIDE-12189
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.Final
>         Environment: 
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>
> As found in JBIDE-12188, JBIDE-9206 and JBIDE-9133 our server adapters keeps assuming everything is in a perfect condition.
> runtime directories, config files, temporary deploy folders etc. are assume to be present even though they might not be (users can have deleted them, servers have been created via API instead of UI etc.) 
> Server adapter should perform checkes for the things it need and if not there handle this error with proper info or creation of the files as needed or even show dialog saying "XYZ is missing/wrong, I can create it for you. Do you wish to create it ? Continue without or Cancel"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira