[jbosstools-issues] [JBoss JIRA] (JBIDE-12469) Creation of org.jboss.tools.common.core component and associated feature

Rob Stryker (JIRA) jira-events at lists.jboss.org
Thu Aug 23 13:01:15 EDT 2012


    [ https://issues.jboss.org/browse/JBIDE-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713399#comment-12713399 ] 

Rob Stryker commented on JBIDE-12469:
-------------------------------------

It will add ambiguity for sure. The problem is that splitting the bundle and renaming the package will break basically every single part of the jboss tools build, until every single component updates all their imports. This is obviously something that simply cannot be done. 

The only other option I can imagine would be as follows:

1) Create the new o.j.t.common.core plugin
2) Copy all relevent classes into o.j.t.common.core with o.j.t.common.core package names
3) do not delete the o.j.t.common varients, but mark them as @deprecated and make them extend the new plugin (deleting the body of the class)

I am fairly certain Max (and others) will not agree to this strategy, as it leaves about 40-45 class "stubs" that are deprecated and who's sole purpose is to sit there with an @Deprecated marker. 

Webtools typically does something like this though. They would sooner introduce a new class in a new package, make the old class extend the new one, mark the old one as @Deprecated, and, perhaps a year later, remove the old stub class. 

But from my experiences with the project, many people will see a big problem with this idea. Many members of the team do not like having empty stub classes with identical names sit around useless, cluttering up their views and complicating their ctrl+shift+t open-type hotkeys. 
                
> Creation of org.jboss.tools.common.core component and associated feature
> ------------------------------------------------------------------------
>
>                 Key: JBIDE-12469
>                 URL: https://issues.jboss.org/browse/JBIDE-12469
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: common/jst/core
>    Affects Versions: 4.0.0.M1
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.0.0.M1
>
>         Attachments: JBIDE-12469.scope2.txt
>
>
> As part of the refactor of the "common" component, this jira will track the addition of a new plugin. Some complain that common already has too many plugins, so this new plugin's creation will follow a careful process to ensure the new plugin has a purpose, is not repetitive, and helps move the component into a cleaner direction rather than a messier one. 
> The process (in progress) is being formed over at https://community.jboss.org/wiki/DevelopingForJBossTools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list