[jbosstools-issues] [JBoss JIRA] (JBIDE-13329) should unified.target includes sources?

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742823#comment-12742823 ] 

Mickael Istria edited comment on JBIDE-13329 at 12/21/12 3:13 AM:
------------------------------------------------------------------

We see sources in multiple.target because we include some ".sdk" feature. Those should simply be removed from target-platforms.

About the "includeSources=true" in unified, I think it's good to keep it. Although site should not contain sources, in case it does, it's still better if one can see them in IDE.
                
      was (Author: mickael_istria):
    We see sources in multiple.target because we include some ".sdk" feature. Those should simply be removed from target-platforms.
                  
> should unified.target includes sources?
> ---------------------------------------
>
>                 Key: JBIDE-13329
>                 URL: https://issues.jboss.org/browse/JBIDE-13329
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: target-platform
>    Affects Versions: 4.0.0.Final
>            Reporter: Nick Boldt
>            Assignee: Mickael Istria
>
> I was under the impression that the generated multiple.target would include source features, while the generated unified.target would not.
> However:
> {code}
> unified-4.2.1.a-20121220.173723-14-unified.target:  
>   <location includeAllPlatforms="false" includeMode="planner" includeSource="true" type="InstallableUnit">
> multiple-4.2.1.a-20121220.173233-14-multiple.target: 
>   <location includeAllPlatforms="false" includeMode="planner" type="InstallableUnit" includeSource="true">
> {code}
> And the generated update site for 4.2.1.a (SR1a) target platform contains many feature.source bundles:
> http://download.jboss.org/jbosstools/updates/juno/SR1a/REPO/features/
> Is this intentional? Or is there a bug in your flatten mojo?
> https://github.com/jbosstools/jbosstools-maven-plugins/blob/master/tycho-plugins/target-platform-utils/src/main/java/org/jboss/tools/tycho/targets/FlattenTargetMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira