[jbosstools-issues] [JBoss JIRA] (JBIDE-10597) Change node name comparison to equalsIgnoreCase(..)

[Denis Maliarevich (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654313#comment-12654313 ] 

Denis Maliarevich commented on JBIDE-10597:
-------------------------------------------

Unnecessary "while" loop was removed.
                
> Change node name comparison to equalsIgnoreCase(..)
> ---------------------------------------------------
>
>                 Key: JBIDE-10597
>                 URL: https://issues.jboss.org/browse/JBIDE-10597
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>    Affects Versions: 3.3.0.M5
>            Reporter: Denis Maliarevich
>            Assignee: Denis Maliarevich
>            Priority: Minor
>             Fix For: 3.3.0.Beta1
>
>         Attachments: rich_stp.jsp
>
>
> Vlado Pakan wrote:
> I would like to make small change to http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java.
> I need to make this small change to doToggle(...) method:
> Current code:
> {code}
> while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
>  selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
> }
> {code}
> Proposed code:
> {code}
> while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
>  selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
> }
> {code}
> Problem is that method selectedElem.getNodeName() returns node name uppercase but HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my tests are failing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira