[jbosstools-issues] [JBoss JIRA] (JBIDE-10565) Wrong EL content assist inside token '#{'

[Victor Rubezhny (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655233#comment-12655233 ] 

Victor Rubezhny edited comment on JBIDE-10565 at 1/11/12 11:08 AM:
-------------------------------------------------------------------

I see no difference between xml and jsp for the issue.

And I see no reason in displaying EL name proposals when user invokes CA from text position like #|{...

The '#'-char is nor EL-starting character, so, IMHO, we shouldn't display EL-proposals here.

The only  one relevant proposal here is "#{" (insert new EL, which propose to insert #{} into a text), because (if we're in position like #|{) the text cursor is not in EL. However, "New JSF EL expression...." proposal is not shown for some reason when CA is manually invoked when text cursor is placed in position like '#|{' (may be it's a bug (?))

Making the CA to provide EL name proposals for the positions like #|{ is possible but requires us to make more sophisticated processing for EL- open&close sequences ("#{" and "}") as well as inserting the additional characters which are not EL-name characters (I mean curly brace "{" into the current cursor position, which in its turn must be right after "#"-char) which aren't trivial.

Once again, IMHO: '#'-character is NOT EL starting sequence, so no EL-proposals should be provided if CA is invoked right after this char.
                
      was (Author: vrubezhny):
    I see no difference between xml and jsp for the issue.

And I see no reason in displaying EL name proposals when user invokes CA from text position like #|{...

The '#'-char is nor EL-starting character, so, IMHO, we shouldn't display EL-proposals here.

The only  one relevant proposal here is "#{" (insert new EL, which propose to insert #{} into a text), because (if we're in position like #|{) the text cursor is not in EL. However, "New JSF EL expression...." proposal is not shown for some reason when CA is manually invoked when text cursor is placed in position like '#|{' (may be it's a bug (?))

Making the CA to provide EL name proposals for the positions like #|{ is possible but requires us to make more sophisticated processing for EL- open&close sequences ("#{" and "}") as well as inserting the additional characters which are not EL-name characters (I mean curly brace "{" into the current cursor position, which in its turn must be right after "#"-char) which aren't trivial ().

Once again, IMHO: '#'-character is NOT EL starting sequence, so no EL-proposals should be provided if CA is invoked right after this char.
                  
> Wrong EL content assist inside token '#{'
> -----------------------------------------
>
>                 Key: JBIDE-10565
>                 URL: https://issues.jboss.org/browse/JBIDE-10565
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: common/jst/core
>    Affects Versions: 3.3.0.M5
>            Reporter: Viacheslav Kabanovich
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.3.0.Beta1
>
>
> EXECUTE: Type #{ in attribute value or in text node in xml.
> EXECUTE: Set cursor  inside that token #|{ and invoke content assist.
> FAILURE: JBoss Tools provide all names available for EL (CDI named beans, Seam components, JSF managed beans and resource bundles, etc.).
> FAILURE: If a proposal 'abc' is selected for insertion, it is inserted in this way: #abc}{.
> ASSERT: JBoss Tools provides nothing for that position.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira