[jbosstools-issues] [JBoss JIRA] (JBIDE-9309) Easily adding full JBoss AS source

[Fred Bricon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662035#comment-12662035 ] 

Fred Bricon commented on JBIDE-9309:
------------------------------------

Snjeza, I just had a quick look at your demo and it looks nice.
I also looked at the code quickly and just FYI, you can remove the boilerplate code in JBossSourceContainer.getArtifactFromMetaInf(...) by using something like 
{code:java}
File jar = ...
org.apache.maven.shared.runtime.MavenRuntime r = new DefaultMavenRuntime();
MavenProjectProperties projectProperties = r.getProjectProperties(jar.toURL());
{code}

We'll probably want to reuse the identification logic from this plugin to implement JBIDE-8973, so you should probably try to start refactoring that part into a separate package. I'll create a JIRA to externalize it to a "common" plugin in the future.
                
> Easily adding full JBoss AS source
> ----------------------------------
>
>                 Key: JBIDE-9309
>                 URL: https://issues.jboss.org/browse/JBIDE-9309
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: JBossAS/Servers
>            Reporter: arjan tijms
>            Assignee: Snjezana Peco
>              Labels: debugging, source
>             Fix For: 3.3.0.Beta1
>
>         Attachments: jbide-9309a.png
>
>
> The JBoss AS server runtime from JBoss tools adds a library container to the classpath of an Eclipse project. This container provides a large amount of jar files that make up JBoss AS itself and the Java EE services it offers.
> Attaching the source code for this is notoriously difficult. Because it concerns a large amount of jar files, attaching source code for each jar is a rather tedious job. 
> For JBoss AS 5, the fact that the location of jars in the source archive was completely different from the structure exposed in Eclipse or the binary build of JBoss AS, made it very hard to actually locate the correct source jar. Sometimes even names were different, making it even harder. 
> For JBoss AS 6, the source archive does not even contain the source for the majority of the JBoss AS artifacts. Source for 'core functionality' (from the point of view of the Java EE developer), like Servlet and JSF is missing. The user has to hunt the Internet to find the correct source for the correct version that JBoss AS 6 uses. This makes an already tedious job even more tedious.
> I would like to request functionality where the user can point to a single _jboss-src.xyz_ file that contains all sources. JBoss tools should then automatically attach the right source from the archive to the right jar from the library container. Alternatively the user could point to a maven repository (but this should not make the Eclipse project dependent on maven).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira