[jbosstools-issues] [JBoss JIRA] (JBIDE-12146) Server adapter wizard: does not recognize existing (imported) project it could use for the adapter

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker reassigned JBIDE-12146:
-----------------------------------

    Assignee: Andre Dietisheim  (was: Rob Stryker)


The code currently does this:

{code}

	/**
	 * This method will search available projects for one that has a git remote
	 * URI that matches that of this IApplication
	 * 
	 * @param application
	 * @return
	 */
	public static IProject[] findProjectsForApplication(final IApplication application) {
		final ArrayList<IProject> results = new ArrayList<IProject>();
		if (application == null)
			return null;
		final String gitUri = application.getGitUrl();
		final IProject[] projects = ResourcesPlugin.getWorkspace().getRoot().getProjects();
		for (int i = 0; i < projects.length; i++) {
			List<URIish> uris = null;
			try {
				uris = EGitUtils.getRemoteURIs(projects[i]);
				Iterator<URIish> it = uris.iterator();
				while (it.hasNext()) {
					String projURI = it.next().toPrivateString();
					if (projURI.equals(gitUri))
						results.add(projects[i]);
				}
			} catch (CoreException ce) {
				// Log? Not 100 required, just skip this project?
			}
		}
		return results.toArray(new IProject[results.size()]);
	}
{code}

What would you suggest is better? Currently we're keying off the shared status of the project and whether it's commit url matches that of the application in the wizard. 
                
> Server adapter wizard: does not recognize existing (imported) project it could use for the adapter
> --------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-12146
>                 URL: https://issues.jboss.org/browse/JBIDE-12146
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 3.3.0.CR1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 3.3.x, 3.4.x
>
>         Attachments: cannot-create-adapter.png, correct-settings-exist.png
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira