[jbosstools-issues] [JBoss JIRA] (JBIDE-12314) Extract file identification API for the Maven Source Lookup Plugin

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705473#comment-12705473 ] 

Snjezana Peco commented on JBIDE-12314:
---------------------------------------

As I can see there is a minor issue in the FileIdentificationManager class.

{code}
@Override
	public ArtifactKey identify(File file) throws CoreException {
		ArtifactKey artifactKey = null;
		for (ArtifactIdentifier identifier : artifactIdentifiers) {
			artifactKey = identifier.identify(file);
			if (artifactKey != null) {
-				break;
+				return artifactKey;
			}
		}
		return null;
	}
{code}







                
> Extract file identification API for the Maven Source Lookup Plugin
> ------------------------------------------------------------------
>
>                 Key: JBIDE-12314
>                 URL: https://issues.jboss.org/browse/JBIDE-12314
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: maven
>    Affects Versions: 3.3.0.Final
>            Reporter: Fred Bricon
>            Assignee: Snjezana Peco
>             Fix For: 3.4.0.M1
>
>         Attachments: extract_file_identification.patch
>
>
> In order to implement JBIDE-8973, we should be able to reuse the file identification algorithms from the Source Lookup plugin.
> This means the identification part from Source Lookup needs to be extracted into an API. Possibly into a separate feature? moved back to the Maven core plugin?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira