[jbosstools-issues] [JBoss JIRA] (JBIDE-12329) Eclipse 4.2 Juno: Rotate editor's icon is missing on toolbar

[Denis Maliarevich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706069#comment-12706069 ] 

Denis Maliarevich commented on JBIDE-12329:
-------------------------------------------

1) SlaveCommandService uses MenuHelper.getIconURI(..) to set the icon to the UI element. And it cannot always find the path to the icon used in ImageDescriptor(especially from FileImageDescriptor). Thus ImageDescriptor should be of type URLImageDescriptor

2) Text is not required, icon is enough. Otherwise text and the icon are displayed altogether on the toolbar.
                
> Eclipse 4.2 Juno: Rotate editor's icon is missing on toolbar
> ------------------------------------------------------------
>
>                 Key: JBIDE-12329
>                 URL: https://issues.jboss.org/browse/JBIDE-12329
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>    Affects Versions: 3.4.0.M1
>            Reporter: Denis Maliarevich
>            Assignee: Denis Maliarevich
>             Fix For: 3.4.0.M1
>
>         Attachments: rotateItemIconMissing.png
>
>
> Rotate editor's icon is missing on toolbar in Eclipse 4.2 Juno.
> Only tooltip is available.
> The problem is that in plugin.xml no icon is specified. And in RotateEditorsHandler icon is not set probably due to some service changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira