[jbosstools-issues] [JBoss JIRA] (JBIDE-11831) Remote server marked as stopped even if stopped failed

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker updated JBIDE-11831:
--------------------------------

    Attachment: 305306.v3.patch


Additions from this patch are the following:

1) a force stop in rse still somehow fell into the graceful stop due to a lack of 'return'

2) Added a synchronous one-time poll before sending the remote stop command over the wire. This way if the server is already stopped, we'll find out. 

3) Moved a method to a util class (the one-time synchronous poll check)

4) The poll thread was never actually canceled if the shutdown command fails. This lead to issues with pollers sticking around polling. 

5) A possible race condition, where the stop command is sent, but the return value takes a while to come back. If the poller recognized the server was stopped at the time, and set server to stopped, the non-zero return value indicating a failed shutdown then set it to started. This of course should not happen. 

In short, I feel the new patch is much more robust, cleans up where appropriate, takes more care in all situations, and should be accepted. 
                
> Remote server marked as stopped even if stopped failed
> ------------------------------------------------------
>
>                 Key: JBIDE-11831
>                 URL: https://issues.jboss.org/browse/JBIDE-11831
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.Beta3
>         Environment: JBT 3.3.0.Beta3 H152
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.3.0.CR1
>
>         Attachments: 305306.v3.patch, JBIDE-11831.patch
>
>
> Similarly to JBIDE-11825, when you stop a remote server and the shutdown command fails to stop the server process for some reason, the tooling will display the server as stopped even if in fact it is still running.
> It the status is Stopped, it should really be stopped.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira