[jbosstools-issues] [JBoss JIRA] (JBIDE-11168) Command 'cd #' not working on windows

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698362#comment-12698362 ] 

Max Rydahl Andersen commented on JBIDE-11168:
---------------------------------------------

A conditional +1 for this patch, see below:

encloseWithDoubleQuotesIfNeeded adds quotes to the string based solely on the string containing a space.

What if the string is already quoted ? i.e. with " or ' at beginning/end ?

This might not be a problem for this specific system property but if it is specified by users or adjustable in any way such string could be quoted already could it not ?

Just the "perfect" patch would only add this if it does not already have " at front and back.
                
> Command 'cd #' not working on windows
> -------------------------------------
>
>                 Key: JBIDE-11168
>                 URL: https://issues.jboss.org/browse/JBIDE-11168
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: forge
>    Affects Versions: 3.3.0.Beta1
>         Environment: jbdevstudio-product-universal-5.0.0.v201203010100M-H88-Beta1, winXP
>            Reporter: Pavol Srna
>            Assignee: Koen Aers
>             Fix For: 3.3.0.CR1
>
>         Attachments: forge.png, JBIDE-11168.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira