[jbosstools-issues] [JBoss JIRA] (JBIDE-12097) Remote AS7 - server stop not detected with JBoss 7 Manager Service poller

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698999#comment-12698999 ] 

Rob Stryker commented on JBIDE-12097:
-------------------------------------

{code}
### Eclipse Workspace Patch 1.0
#P org.jboss.ide.eclipse.as.core
Index: jbosscore/org/jboss/ide/eclipse/as/core/server/internal/v7/JBoss7ManagerServicePoller.java
===================================================================
--- jbosscore/org/jboss/ide/eclipse/as/core/server/internal/v7/JBoss7ManagerServicePoller.java	(revision 41709)
+++ jbosscore/org/jboss/ide/eclipse/as/core/server/internal/v7/JBoss7ManagerServicePoller.java	(working copy)
@@ -195,7 +195,7 @@
 		} catch (JBoss7ManangerConnectException e) {
 			return true;
 		} catch (Exception e) {
-			return false;
+			return true;
 		}
 	}
 
{code}

That's the patch!  It seems my catch-all exception was returning the wrong value. I could simplify this to get rid of the redundancy of two catches, but I don't think that's a priority right now. 
                
> Remote AS7 - server stop not detected with JBoss 7 Manager Service poller
> -------------------------------------------------------------------------
>
>                 Key: JBIDE-12097
>                 URL: https://issues.jboss.org/browse/JBIDE-12097
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.CR1
>         Environment: jbdevstudio-product-universal-5.0.0.v20120605-0238-H182-CR1.jar
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.3.0.CR1
>
>         Attachments: passwd-prompt.png
>
>
> When you set up a remote JBoss AS 7.1.1 server, check "Expose your management port..." and set both pollers to JBoss 7 Manager Service, the server stop is not recognized properly. It keeps stopping until timeout is hit. During this time you cannot even click Stop again to force the stop. And when the timeout is reached, an empty error message is printed in the log:
> {code}
> !ENTRY org.jboss.ide.eclipse.as.core 4 16842768 2012-06-05 10:11:49.470
> !MESSAGE 
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira