[jbosstools-issues] [JBoss JIRA] (JBIDE-12087) JDS5 beta 3 crashes when importing JBoss AS 7.1.1.Final Maven project

Thu Jun 7 04:43:18 EDT 2012

    [ https://issues.jboss.org/browse/JBIDE-12087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699681#comment-12699681 ] 

Max Rydahl Andersen commented on JBIDE-12087:
---------------------------------------------

>> Snejzana - you seem to be ignoring the point of m2e-apt.

>I understand what your intention in adding m2e-apt was. I have said that we can't know if the user needs AP and, if he does need it, which jars >need to be included in .factorypath. The most simple way to do it is to add the correct .factorypath to the project. Adding all jars to >.factorypath isn't correct.

.factorypath is *only* for Eclipse APT, m2e-apt has option to not use Eclipse APT.

Thus using .factorypath by default is not the right answer either.

>This is the reason why I think the AP processor is correctly defined in WELD-835.

of course it is defined right in there - its what matches specifically for that project.

>We could do this some other way, but would have to have the following information:

>AP needs/doesn't need to be enabled

Don't understand what you mean here - it make sense to enable for those that has an annotation processor on their project.

I do agree that it would be better if we could have a way to let user control/configure this.
Maybe look for if the annotation processor is disabled during compilation or something.

>>if AP needs to be enabled, what jars/folders to include in the Eclipse APT generator
>>What is sane or rather is problematic is that we cannot guard against "bad annotation processors" such as the JBoss Logging + userclasses with >>refs to JBoss Modules that tweak the running vm.

>If you mean LoggingToolsProcessor, this processor will work regularly if you add:

>jboss-logging-processor.jar
>jboss-logging.jar
>tools.jar
>org.eclipse.jst.ws.annotations.core (PLUGIN)

>to .factorypath

And none of that is deducible - thus it is not an option. Something else is needed.

btw. why should users add a plugin to the annotation path !?

> However, when adding all the jars to the .factorypath, Eclipse will crash.

Yes, because the annotation processor is implemented badly. See https://issues.jboss.org/browse/LOGTOOL-51.
The annotation processor shouldn't even need the Logger library classes.

But sure, we should find a better way to reduce the size of the classpath.

>>Beyond that you mention performance impact because all annotation processors are active - please take that to a separate issue and say where >>this is a problem since annotationprocessors are not invoked unless users classes actually have the annotation types they refer to; so this >>should have minimal impact.

>If AP is enabled, it has to check if the user classes have or don't have annotations types each time when some class is changed.

And this is taking noticeable time ?

>But, that is not the only problem with performance. The main problem is searching META-INF/services/xxxx resources.

This performance problem is a separate issue - please move it to another jira and quantify the problem.
And from m2e-apt side its just done on reconfigure project side afaics. again, please move that to a separate issue and lets keep this about how m2e-apt can avoid things to crash.

m2e-apt for now is off by default because of this. 

> JDS5 beta 3 crashes when importing JBoss AS 7.1.1.Final Maven project
> ---------------------------------------------------------------------
>
>                 Key: JBIDE-12087
>                 URL: https://issues.jboss.org/browse/JBIDE-12087
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: maven
>         Environment: $ uname -a
> Linux ichindar.localdomain 3.3.7-1.fc17.x86_64 #1 SMP Mon May 21 22:32:19 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
> $ lsb_release -a
> LSB Version:	:core-4.0-amd64:core-4.0-noarch
> Distributor ID:	Fedora
> Description:	Fedora release 17 (Beefy Miracle)
> Release:	17
> Codename:	BeefyMiracle
> $ java -version
> java version "1.7.0_b147-icedtea"
> OpenJDK Runtime Environment (fedora-2.1.fc17.6-x86_64)
> OpenJDK 64-Bit Server VM (build 22.0-b10, mixed mode)
>            Reporter: Craig Ringer
>            Assignee: Fred Bricon
>            Priority: Blocker
>             Fix For: 3.3.0.CR1
>
>         Attachments: import-error-log.log.gz
>
>
> When attempting to import JBoss AS 7.1.1.Final, checked out from git, as a Maven project into JBoss Developer Studio 5.0 beta 3 on an x64 Fedora machine with JDK7, JBoss Developer Studio becomes unresponsive partway through the import. It sometimes then fails with an error message, and sometimes just ends up stuck in what appears to be some kind of infinite loop until killed.
> I haven't installed any add-ons or extras, it's stock JBoss Developer Studio 5.0 Beta 3.
> I've tried increasing the memory parameters from the already generous initial allocations to:
> -Xms512m
> -Xmx1592m
> with no improvement. I have 8GB to play with so I'll be throwing a ridiculous amount of RAM at and trying again, but this should not be necessary in any case, not just to *import* a maven project, even a big one.
> All I'm trying to do is import AS7 so I can add the AS7 project to the source search path when debugging a test case that's triggering a bug in AS7, so I don't have to manually add each and every source jar from as7 to my source search path. This seemed like the easy way to do it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira