[jbosstools-issues] [JBoss JIRA] (JBIDE-12134) StackOverflow when importing into existing project

[Andre Dietisheim (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andre Dietisheim updated JBIDE-12134:
-------------------------------------

    Attachment: validate-in-ui.patch


I suspect a bad implementation of the MultiValidator. The golden rule with MultiValidator is that you have to access all observables that are participating in the validation. This is not the case in the current implementation since validation occurrs in the model (@see ProjectAndServerAdapterSettingsWizardPageModel#setProjectName & ProjectAndServerAdapterSettingsWizardPageModel#setNewProject - both call #validateExistingProject).
I moved the validation from the model to the UI and implemented a MultiValidator in the way it is implemented in all other pages. It now accesses all observables that participate to the validation:
- applicationName
- projectName
- isNewProject (checkbox) 
                
> StackOverflow when importing into existing project
> --------------------------------------------------
>
>                 Key: JBIDE-12134
>                 URL: https://issues.jboss.org/browse/JBIDE-12134
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>    Affects Versions: 3.3.0.CR1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>            Priority: Critical
>             Fix For: 3.3.0.CR1
>
>         Attachments: stack-overflow.png, validate-in-ui.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira