[jbosstools-issues] [JBoss JIRA] (JBIDE-10391) an existing .gitignore should get merged

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672652#comment-12672652 ] 

Andre Dietisheim edited comment on JBIDE-10391 at 3/1/12 9:17 AM:
------------------------------------------------------------------

In most project I was involved (before Red Hat) in, Eclipse specific configuration files were considered as non-project files which were not committed to the source control system. Even more if there were project members that were not working with Eclipse (but intellij, netbeans etc.). The same applies if you consider that the default project, that is created when you create a new openshift application, does not have any eclipse specific files. 
By adding those configuration files to the gitignore we prevent them from being committed to the OpenShift git repo and keep them local (since they were created when importing the app to the local workspace).
Therefore, the current behaviour is a reasonable default to me. The user may still remove those entries from gitignore manually and commit the eclipse files if he wants to.
                
      was (Author: adietish):
    In most project I was involved (before Red Hat), eclipse specific configuration files were considered as non-project files which were not committed to the source control system. Even more if there were project members that were not working with eclipse (but intellij, netbeans etc.). Even more if you consider that the default project, that is created when you create a new openshift application - does not have any eclipse specific files. By adding those eclipse configuration files to the gitignore we prevent them from being committed to the OpenShift git repo, we keep them local since they were created when importing the app to the local workspace.
Therefore, the current behaviour is a reasonable default to me. The user may still remove those entries from gitignore manually and commit the eclipse files if he wants to.
                  
> an existing .gitignore should get merged
> ----------------------------------------
>
>                 Key: JBIDE-10391
>                 URL: https://issues.jboss.org/browse/JBIDE-10391
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 3.3.0.M4
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 3.3.0.Beta1
>
>
> In the usecase, where we push an existing workspace project to OpenShift, we create a .gitingore file if there's none so far. If the project already has a .gitingore file, we just leave it alone.
> We should enhance this and just add the missing entries (merge the existing content).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira