[jbosstools-issues] [JBoss JIRA] (JBIDE-10527) NullPointerException when creating OpenShift server manually

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673011#comment-12673011 ] 

Rob Stryker commented on JBIDE-10527:
-------------------------------------

Yes: The fix is to simply initialize the wizard as incomplete.  Lucia wrote:

1. When starting Eclipse, choose new clean workspace
2. Open New Server wizard, choose Openshift server and click Finish
3. The error message with NullPointerException message is displayed.

However, if you press next on the New Server wizard (it brings you to openshift wizard page), this issue will never occur again. From now on the Finish button on the first wizard page will be disabled. 


---

You can see here that he clicks finish without going into the openshift page. This means finish was enabled when the user never went to the second page. This means all the model initialization and saving of server settings inside the serverworkingcopy is never performed, and user clicks finish. 

Setting the wizard to initialize as incomplete (which it always is via this usecase) ensures that users must actually enter the page and follow the proper workflow. 

The fix is to initialize the fragment as incomplete
                
> NullPointerException when creating OpenShift server manually
> ------------------------------------------------------------
>
>                 Key: JBIDE-10527
>                 URL: https://issues.jboss.org/browse/JBIDE-10527
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 3.3.0.M5
>            Reporter: Lucia Jelinkova
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.3.0.Beta1
>
>         Attachments: JBIDE-10527.patch
>
>
> When I try to create an OpenShift server manually, the server is created successfully but keeps throwing the following NullPointerException every time I click on it.
> java.lang.NullPointerException
> 	at org.jboss.ide.eclipse.as.core.server.internal.DelegatingServerBehavior.getDelegate(DelegatingServerBehavior.java:58)
> 	at org.jboss.ide.eclipse.as.core.server.internal.DelegatingServerBehavior.canChangeState(DelegatingServerBehavior.java:158)
> 	at org.jboss.ide.eclipse.as.core.server.internal.DelegatingServerBehavior.canStop(DelegatingServerBehavior.java:150)
> 	at org.eclipse.wst.server.core.internal.Server.canStop(Server.java:1833)
> 	at org.eclipse.wst.server.ui.internal.view.servers.StopAction.accept(StopAction.java:50)
> 	at org.eclipse.wst.server.ui.internal.view.servers.AbstractServerAction.selectionChanged(AbstractServerAction.java:85)
> 	at org.eclipse.ui.actions.SelectionProviderAction.selectionChanged(SelectionProviderAction.java:143)
> 	at org.eclipse.jface.viewers.Viewer$2.run(Viewer.java:164)
> 	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> 	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
> 	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
> 	at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:162)
> 	at org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:2188)
> 	at org.eclipse.jface.viewers.StructuredViewer.handleSelect(StructuredViewer.java:1211)
> 	at org.eclipse.ui.navigator.CommonViewer.handleSelect(CommonViewer.java:478)
> 	at org.eclipse.jface.viewers.StructuredViewer$4.widgetSelected(StructuredViewer.java:1241)
> 	at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent(OpenStrategy.java:239)
> 	at org.eclipse.jface.util.OpenStrategy.access$4(OpenStrategy.java:233)
> 	at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:403)
> 	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
> 	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)
> 	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
> 	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
> 	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
> 	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
> 	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> 	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
> 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
> 	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
> 	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
> 	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira