[jbosstools-issues] [JBoss JIRA] (JBIDE-11135) Non saved credentials are remembered even after Eclipse restart

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673917#comment-12673917 ] 

Max Rydahl Andersen commented on JBIDE-11135:
---------------------------------------------

1) Why is IPasswordPrompter not returning something more structured than an Object array ? Or simply have two methods - getPassword(IUser) and shouldSavePassword(IUser) ? Or a map with documented keys.

2) There is a catch Exception in checkForPassword - why is it not logging or being handled more explicit ?

3) the description for getPassordFor  is different in interface and implementation. i.e. one says null is valid value in case it could not open the dialog. 

4) The patch seems unnecessary big since most is formatting changes. Please dont run formatting in a branch.

5) Why call it UserDelegator instead of simply UIUser since that is what it is vs IUser which is in the client model. And if it is more like a delegate call it UserDelegate ?
                
> Non saved credentials are remembered even after Eclipse restart
> ---------------------------------------------------------------
>
>                 Key: JBIDE-11135
>                 URL: https://issues.jboss.org/browse/JBIDE-11135
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 3.3.0.Beta1
>            Reporter: Lucia Jelinkova
>            Assignee: Max Rydahl Andersen
>            Priority: Critical
>             Fix For: 3.3.0.Beta1
>
>         Attachments: JBIDE-11135.patch
>
>
> When I connect to OpenShift and select not to store the password, it is remembered even after Eclipse restart. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira