[jbosstools-issues] [JBoss JIRA] (JBIDE-11308) server adapter adds .dodeploy before Clean/publish has finished
Rob Stryker (JIRA)
jira-events at lists.jboss.org
Wed Mar 14 13:17:49 EDT 2012
[ https://issues.jboss.org/browse/JBIDE-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676825#comment-12676825 ]
Rob Stryker edited comment on JBIDE-11308 at 3/14/12 1:17 PM:
--------------------------------------------------------------
File copying definitely occurs before the do-deploy markers.
{code}
@Override
protected void publishFinish(IProgressMonitor monitor) throws CoreException {
// Handle the dodeploy
try {
createDoDeployMarkers(monitor);
} finally {
super.publishFinish(new SubProgressMonitor(monitor, 1));
}
}
{code}
The file markers are added during publishFinish, and the file copying is done in publishModule, which is 100% of the time called before publish finish.
is this just some feeling you have, or have you definitely reproduced it and know this is happening? Or are you just saying it SEEMS that way?
I've added some logging to the general workflow, and really, it's quite impossible that it's adding .dodeploy before copying the files. Really quite impossible. The files are all copied in the same thread and publishFinish is necessarily called after publishModule has finished.
{code}
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.237 -->-- Publishing to server: JBoss 7.0.2 Runtime Server -->--
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.237 Server.publishImpl(): kind=<clean> modules=null
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.238 ->- Firing publish started event ->-
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.238 Firing publish started event to org.jboss.ide.eclipse.as.core.server.UnitedServerListenerManager at 52c4d93
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.238 Firing publish started event to org.eclipse.wst.server.ui.internal.ServerUIPlugin$3 at 5f548499
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.238 Firing publish started event to org.eclipse.wst.server.ui.internal.cnf.ServersView2$7 at 52d1ce4c
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.238 -<- Done firing publish started event -<-
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.238 -->-- Publishing to server: JBoss 7.0.2 Runtime Server -->--
org.eclipse.wst.server.core /performance 15/03/12 01:18.49.239 Filling publish cache for TomCatDyn: 1
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.239 Starting publish
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.239 Publish Start in DeployableServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.239 Creating publish method org.jboss.ide.eclipse.as.core.publishers.LocalPublishMethod
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.239 Publish start in org.jboss.ide.eclipse.as.core.publishers.LocalPublishMethod
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.240 Performing tasks: 0
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.240 Executing publishers: 0
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.240 -->-- Publishing module
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.240 Module: Module[TomCatDyn,org.eclipse.jst.j2ee.server:TomCatDyn]
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.240 Beginning to publish module TomCatDyn in DeployableServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.240 Beginning to publish module TomCatDyn
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.241 Publisher for module TomCatDyn is org.jboss.ide.eclipse.as.core.server.internal.v7.JBoss7JSTPublisher
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.241 Using AS7 publishModule logic in JBoss7JSTPublisher for module TomCatDyn
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.246 Begin Handling a full publish for module TomCatDyn
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.252 full publish completed for module TomCatDyn
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.255 Marking path /home/rob/apps/eclipse/workspaces/runtime-New_configuration_garbage2/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_7.0.2_Runtime_Server1331657540320/deploy/TomCatDyn.war as requiring a .dodeploy marker, but NOT creating the file yet
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.255 --<-- Done publishing module
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.255 PublishFinish in DelegatingJBoss7ServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.256 Marking 1 dodeploy files.
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.257 Creating dodeploy file: /home/rob/apps/eclipse/workspaces/runtime-New_configuration_garbage2/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_7.0.2_Runtime_Server1331657540320/deploy/TomCatDyn.war.dodeploy
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.257 PublishFinish in DelegatingServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.257 PublishFinish in DeployableServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.257 Beginning publishFinish in org.jboss.ide.eclipse.as.core.publishers.LocalPublishMethod
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:18.49.257 Ending publishFinish with server restart state of 1
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.257 --<-- Done publishing --<--
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.258 Saving publish info to /home/rob/apps/eclipse/workspaces/runtime-New_configuration_garbage2/.metadata/.plugins/org.eclipse.wst.server.core/publish/publish1.dat
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.258 ->- Firing publishing finished event: Status OK: unknown code=0 OK null ->-
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.258 Firing publishing finished event to org.jboss.ide.eclipse.as.core.server.UnitedServerListenerManager at 52c4d93
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.258 Firing publishing finished event to org.eclipse.wst.server.ui.internal.ServerUIPlugin$3 at 5f548499
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.258 Firing publishing finished event to org.eclipse.wst.server.ui.internal.cnf.ServersView2$7 at 52d1ce4c
org.eclipse.wst.server.core /finest 15/03/12 01:18.49.259 -<- Done firing publishing finished event -<-
org.eclipse.wst.server.core /performance 15/03/12 01:18.49.259 Server.publishImpl(): <22> org.jboss.ide.eclipse.as.70
{code}
was (Author: rob.stryker):
File copying definitely occurs before the do-deploy markers.
{code}
@Override
protected void publishFinish(IProgressMonitor monitor) throws CoreException {
// Handle the dodeploy
try {
createDoDeployMarkers(monitor);
} finally {
super.publishFinish(new SubProgressMonitor(monitor, 1));
}
}
{code}
The file markers are added during publishFinish, and the file copying is done in publishModule, which is 100% of the time called before publish finish.
is this just some feeling you have, or have you definitely reproduced it and know this is happening? Or are you just saying it SEEMS that way?
I've added some logging to the general workflow, and really, it's quite impossible that it's adding .dodeploy before copying the files. Really quite impossible. The files are all copied in the same thread and publishFinish is necessarily called after publishModule has finished.
{code}
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.241 -->-- Publishing to server: JBoss 7.0.2 Runtime Server -->--
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.242 Server.publishImpl(): kind=<clean> modules=null
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.242 ->- Firing publish started event ->-
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.242 Firing publish started event to org.jboss.ide.eclipse.as.core.server.UnitedServerListenerManager at 52c4d93
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.242 Firing publish started event to org.eclipse.wst.server.ui.internal.ServerUIPlugin$3 at 5f548499
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.242 Firing publish started event to org.eclipse.wst.server.ui.internal.cnf.ServersView2$7 at 52d1ce4c
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.242 -<- Done firing publish started event -<-
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.242 -->-- Publishing to server: JBoss 7.0.2 Runtime Server -->--
org.eclipse.wst.server.core /performance 15/03/12 01:02.01.243 Filling publish cache for TomCatDyn: 1
org.eclipse.wst.server.core /finest 15/03/12 01:02.01.243 Starting publish
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.185 Publish Start in DeployableServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.185 Creating publish method org.jboss.ide.eclipse.as.core.publishers.LocalPublishMethod
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.185 Publish start in org.jboss.ide.eclipse.as.core.publishers.LocalPublishMethod
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.186 Performing tasks: 0
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.186 Executing publishers: 0
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.186 -->-- Publishing module
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.186 Module: Module[TomCatDyn,org.eclipse.jst.j2ee.server:TomCatDyn]
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.187 Beginning to publish module TomCatDyn in DeployableServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.187 Beginning to publish module TomCatDyn
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.187 Publisher for module TomCatDyn is org.jboss.ide.eclipse.as.core.server.internal.v7.JBoss7JSTPublisher
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.204 --<-- Done publishing module
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.204 PublishFinish in DelegatingJBoss7ServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.204 Marking 1 dodeploy files.
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.205 Creating dodeploy file: /home/rob/apps/eclipse/workspaces/runtime-New_configuration_garbage2/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_7.0.2_Runtime_Server1331657540320/deploy/TomCatDyn.war.dodeploy
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.205 PublishFinish in DelegatingServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.205 PublishFinish in DeployableServerBehavior
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.205 Beginning publishFinish in org.jboss.ide.eclipse.as.core.publishers.LocalPublishMethod
org.jboss.ide.eclipse.as.core /finer 15/03/12 01:02.05.205 Ending publishFinish with server restart state of 1
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.205 --<-- Done publishing --<--
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.205 Saving publish info to /home/rob/apps/eclipse/workspaces/runtime-New_configuration_garbage2/.metadata/.plugins/org.eclipse.wst.server.core/publish/publish1.dat
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.206 ->- Firing publishing finished event: Status OK: unknown code=0 OK null ->-
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.206 Firing publishing finished event to org.jboss.ide.eclipse.as.core.server.UnitedServerListenerManager at 52c4d93
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.206 Firing publishing finished event to org.eclipse.wst.server.ui.internal.ServerUIPlugin$3 at 5f548499
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.206 Firing publishing finished event to org.eclipse.wst.server.ui.internal.cnf.ServersView2$7 at 52d1ce4c
org.eclipse.wst.server.core /finest 15/03/12 01:02.05.206 -<- Done firing publishing finished event -<-
org.eclipse.wst.server.core /performance 15/03/12 01:02.05.206 Server.publishImpl(): <3964> org.jboss.ide.eclipse.as.70
{code}
> server adapter adds .dodeploy before Clean/publish has finished
> ---------------------------------------------------------------
>
> Key: JBIDE-11308
> URL: https://issues.jboss.org/browse/JBIDE-11308
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: JBossAS/Servers
> Reporter: Max Rydahl Andersen
> Assignee: Max Rydahl Andersen
> Priority: Critical
> Fix For: 3.3.0.Beta2
>
>
> EXECUTE: import decent sized project, i.e. GWT project from central and follo the readme regarding tooling
> EXECUTE: after Run As have been done, right click server and press Clean...
> ASSERT: clean is done and publish goes on and then in the end .dodeploy file occurrs
> What actually seem to happen is deploymen is removed, dir added, then .dodeploy and *then* file copying occurs - causing the scanner to pickup partially deployed project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jbosstools-issues
mailing list