[jbosstools-issues] [JBoss JIRA] (JBIDE-11308) server adapter adds .dodeploy before Clean/publish has finished

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677003#comment-12677003 ] 

Rob Stryker commented on JBIDE-11308:
-------------------------------------

IT's all the same progress monitor.  The root publish in IServer gets called with one progress monitor. The rest get sub-monitors. The progress monitor in eclipse will not finish until after JBT writes the doDeploy file, flow of execution is passed back to wtp, which does its own cleanup of its own apis, and then the job is complete. 

tl;dr:  Writing .dodeploy is done in what is basically the same progress monitor as the rest of the publish. publishFinish is still part of the publish Job. 

Also, to be clear, if there are several modules with child modules, that is all done in a loop of publishModule calls, before publishFinish is called. So in that case, one publish job will write blah.ear,  blah.ear/web.war,   blah.ear/web.war/inner.jar,   blah.ear/someejb.jar, (this is the loop of publishModule calls), and once all that is done, it will go to publishFinish, which will add the dodeploy markers. 

If you mean in a SUBSEQUENT call of the publish job, (which i believe you don't), then by that point, the original .dodeploy has alreayd been removed and replaced with a .deployed.  And, as always, the second job will write out the entire file tree before adding any markers. 

Again: Are you actually replicating this in any fashion? Or are you just saying what "seems" to be happening? 
                
> server adapter adds .dodeploy before Clean/publish has finished
> ---------------------------------------------------------------
>
>                 Key: JBIDE-11308
>                 URL: https://issues.jboss.org/browse/JBIDE-11308
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.3.0.Beta2
>
>
> EXECUTE: import decent sized project, i.e. GWT project from central and follo the readme regarding tooling
> EXECUTE: after Run As have been done, right click server and press Clean...
> ASSERT: clean is done and publish goes on and then in the end .dodeploy file occurrs
> What actually seem to happen is deploymen is removed, dir added, then .dodeploy and *then* file copying occurs - causing the scanner to pickup partially deployed project.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira