[jbosstools-issues] [JBoss JIRA] (JBIDE-11372) Hibernate Query Result view gets dramatically slow when query text has '\t' characters

[Viacheslav Kabanovich (JIRA)]

Viacheslav Kabanovich created JBIDE-11372:
---------------------------------------------

             Summary: Hibernate Query Result view gets dramatically slow when query text has '\t' characters
                 Key: JBIDE-11372
                 URL: https://issues.jboss.org/browse/JBIDE-11372
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: hibernate
    Affects Versions: 3.3.0.Beta1
            Reporter: Viacheslav Kabanovich
            Assignee: Dmitry Geraskov
             Fix For: 3.3.0.Beta3


EXECUTE: Open HQL Editor, and type some long query using tabs (\t) instead of usual whitespaces.
EXECUTE: Send the query into Hibernate Query Result view.
ASSERT: New tab folder is added to the view in 1-2 seconds even for queries as long as 1000 characters.
ASSERT: Resize of the view goes without delays.
FAILURE: For a query of 120 characters, including 15 \t characters, creation of new tab folder, and each subsequent resize of the view takes 7 seconds. Doubling text size increases time 8 times.

SWT methods CTabFolderRenderer.shortenText(GC, String, int, String), TextLayout.getPreviousOffset(int,int), GC.textExtent(String,int) have poor performance for long strings with \t characters. I have created issue https://bugs.eclipse.org/bugs/show_bug.cgi?id=374987

Class HQLQueryPage sets tab name as 
{code}
setTabName(getQueryString().replace('\n', ' ').replace('\r', ' '));
{code}
This issue may be solved by modifying it as

{code}
setTabName(getQueryString().replace('\n', ' ').replace('\r', ' ').replace('\t', ' '));
{code}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira