[jbosstools-issues] [JBoss JIRA] (JBIDE-10460) Openshift Express: Vertical scroll bar dose not work in embedded cartridge result output page

[Daniel Azarov (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678826#comment-12678826 ] 

Daniel Azarov commented on JBIDE-10460:
---------------------------------------

May be it can help:

I took a look to org.jboss.tools.openshift.express.internal.ui.wizard.CreationLogDialog.createDialogArea(Composite parent):

{code}
@Override
	protected Control createDialogArea(Composite parent) {
		Composite container = new Composite(parent, SWT.NONE);
		GridDataFactory.fillDefaults().align(SWT.FILL, SWT.FILL).grab(true, true).applyTo(container);
		GridLayoutFactory.fillDefaults().margins(6, 6).applyTo(container);

		Label separator = new Label(container, SWT.HORIZONTAL | SWT.SEPARATOR);
		GridDataFactory.fillDefaults().align(SWT.FILL, SWT.TOP).grab(true, false).applyTo(separator);

		StyledText logText = new StyledText(container, SWT.BORDER | SWT.V_SCROLL);
		GridDataFactory.fillDefaults().align(SWT.FILL, SWT.TOP).grab(true, false).applyTo(logText);
		writeLogEntries(createLogEntries(), logText);
		logText.addListener(SWT.MouseDown, onLinkClicked(logText));
		return container;
	}
{code}

It looks like wrong usage of GridDataFactory.fillDefaults().align()

>From JavaDoc:
@param hAlign horizontal alignment. One of SWT.BEGINNING, SWT.CENTER, SWT.END, or SWT.FILL.
@param vAlign vertical alignment. One of SWT.BEGINNING, SWT.CENTER, SWT.END, or SWT.FILL.

Probably we should try SWT.FILL instead of SWT.TOP for parameter vAlign

Now I have problems with new OpenShift Application creation so I can't test it.
May be someone else can do?
                
> Openshift Express: Vertical scroll bar dose not work in embedded cartridge result output page
> ---------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-10460
>                 URL: https://issues.jboss.org/browse/JBIDE-10460
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 3.3.0.M5
>         Environment: Fedora15_i686 with screen resolution : 1680x1050
>            Reporter: meng bo
>            Assignee: Andre Dietisheim
>             Fix For: 3.3.0.Beta3
>
>         Attachments: 2011-12-13-Embedded_cartridge_output.png
>
>
> Steps:
> 1. Create an Openshift application.
> 2. Edit this application and embedded more than four cartridge at one time.
> 3. Wait the result output page comes.
> Actual result:
> The vertical scroll bar doesn't work, and the cartridges information will show incomplete.
> (In my case, there are 6 cartridges embedded and only showed about 4 of them.)
> !2011-12-13-Embedded_cartridge_output.png!
> Expect result:
> The vertical scroll bar should work as usual.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira