[jbosstools-issues] [JBoss JIRA] (JBIDE-11374) BUILD USABILITY BUG: build should assume target platform is in build/target-platform/REPO

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680119#comment-12680119 ] 

Nick Boldt edited comment on JBIDE-11374 at 3/28/12 2:13 PM:
-------------------------------------------------------------

${target.platform.version} is undefined. Is that a typo, or does it need to be set somewhere as a new <property> ?

Alternatively, how about this patch to the parent pom? 

Idea is to set a new default for users building locally, and use the "hudson" profile to automatically revert to the current default when run in Jenkins.

{code}
diff --git a/build/parent/pom.xml b/build/parent/pom.xml
index 4e983c1..d314157 100644
--- a/build/parent/pom.xml
+++ b/build/parent/pom.xml
@@ -37,7 +37,7 @@
 
                <!-- 1b. or use -Plocal.site -Dlocal.site=file:///home/$user/trunk/build/target-platform/REPO/ -->
                <!-- TODO: don't forget to update JBDS .updatesite jobs when this value changes! -->
-               <local.site>file:///home/hudson/static_build_env/jbds/target-platform_3.3.indigo.SR2/e372M-wtp332M.target/</local.site>
+               <local.site>file:///${user.home}/jbosstools-target-${JBT_VERSION}.${BUILD_ALIAS}</local.site>
 
                <!-- 2a. URL of latest JBT nightly staging composite site (all the components 
                        in once place) -->
@@ -585,6 +585,9 @@
                                        <name>BUILD_NUMBER</name>
                                </property>
                        </activation>
+                       <properties>
+                               <local.site>file:///home/hudson/static_build_env/jbds/target-platform_3.3.indigo.SR2/e372M-wtp332M.target/</local.site>
+                       </properties>
                        <build>
{code}

For me, local.site=file:///${user.home}/jbosstools-target-${JBT_VERSION}.${BUILD_ALIAS} resolves to file:////home/nboldt/jbosstools-target-3.3.0.Beta3. 
                
      was (Author: nickboldt):
    ${target.platform.version} is undefined. Is that a typo, or does it need to be set somewhere as a new <property> ?

Alternatively, how about this patch to the parent pom? 

Idea is to set a new default for users building locally, and use the "hudson" profile to automatically revert to the current default when run in Jenkins.

{code}
diff --git a/build/parent/pom.xml b/build/parent/pom.xml
index 4e983c1..d314157 100644
--- a/build/parent/pom.xml
+++ b/build/parent/pom.xml
@@ -37,7 +37,7 @@
 
                <!-- 1b. or use -Plocal.site -Dlocal.site=file:///home/$user/trunk/build/target-platform/REPO/ -->
                <!-- TODO: don't forget to update JBDS .updatesite jobs when this value changes! -->
-               <local.site>file:///home/hudson/static_build_env/jbds/target-platform_3.3.indigo.SR2/e372M-wtp332M.target/</local.site>
+               <local.site>file:///${user.home}/jbosstools-target-${JBT_VERSION}.${BUILD_ALIAS}</local.site>
 
                <!-- 2a. URL of latest JBT nightly staging composite site (all the components 
                        in once place) -->
@@ -585,6 +585,9 @@
                                        <name>BUILD_NUMBER</name>
                                </property>
                        </activation>
+                       <properties>
+                               <local.site>file:///home/hudson/static_build_env/jbds/target-platform_3.3.indigo.SR2/e372M-wtp332M.target/</local.site>
+                       </properties>
                        <build>
{code}
                  
> BUILD USABILITY BUG:  build should assume target platform is in build/target-platform/REPO
> ------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-11374
>                 URL: https://issues.jboss.org/browse/JBIDE-11374
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Build/Releng
>    Affects Versions: 3.3.0.Beta3
>            Reporter: Rob Stryker
>            Assignee: Nick Boldt
>             Fix For: 3.3.0.CR1
>
>
> If I run the command:  mvn clean install -f ../build/pom-core.xml -Parchives-bootstrap,default,local.site  -Dmaven.test.skip=true
> Then the build system assumes we're running on hudson. The error is:
> {code}
> [ERROR] Internal error: java.lang.RuntimeException: java.lang.RuntimeException: org.eclipse.equinox.p2.core.ProvisionException: No repository found at file:/home/hudson/static_build_env/jbds/target-platform_3.3.indigo.SR2/e372M-wtp332M.target/. -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: java.lang.RuntimeException: org.eclipse.equinox.p2.core.ProvisionException: No repository found at file:/home/hudson/static_build_env/jbds/target-platform_3.3.indigo.SR2/e372M-wtp332M.target/.
> {code}
> Our documentation, however, insists we put the repo over in build/target-platform/REPO/.  If our documentation wants the target-platform there, then the build system should assume it is there first, rather than assume it is in a hudson-specific location.   Documentation:  https://community.jboss.org/wiki/HowToBuildJBossToolsWithMaven3
> Currently, if no local.site is set, it assumes it will be at file:/home/hudson/static_build_env/jbds/target-platform_3.3.indigo.SR2/e372M-wtp332M.target/,  but really it should assume it is at ../build/target-platform/REPO/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira