[jbosstools-issues] [JBoss JIRA] (JBIDE-10666) Delete OpenShift domain with JBoss tooling

[Daniel Azarov (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680722#comment-12680722 ] 

Daniel Azarov commented on JBIDE-10666:
---------------------------------------

>On MacOSX (and Windows I believe), the 'Delete domain' context menu item misses an icon.
I'll try to figure out.

>Also, wouldn't it make more sense to always have the action visible, but disabled when the domain still has applications ?

It can be done for all menu items or for none.
See AbstractActionProvider.fillContextMenu:
{code}
@Override
	public void fillContextMenu(IMenuManager menu) {
		action.validate();
		if (action != null && action.isEnabled()) {
			menu.appendToGroup(group, action);
		}
	}
{code}
I can do it just by removing part "&& action.isEnabled()"

>With the new REST API, we'll also be able to destroy a domain using a 'force=true' param to include the domain's applications at the same time.
No problem. If in the future DeleteDomainAction will be able to delete domain with applications we just will need to change method DeleteDomainAction.validate()
                
> Delete OpenShift domain with JBoss tooling
> ------------------------------------------
>
>                 Key: JBIDE-10666
>                 URL: https://issues.jboss.org/browse/JBIDE-10666
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: openshift
>    Affects Versions: 3.3.0.M5
>            Reporter: Stefan Bunciak
>            Assignee: Daniel Azarov
>             Fix For: 3.3.0.Beta3
>
>         Attachments: Confirm.png, DeleteDomain.png, JBIDE-10666.patch
>
>
> OpenShift wizard should provide a way how to remove domain, as the CLI client supports it (rhc-ctl-domain with --destroy argument).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira