[jbosstools-issues] [JBoss JIRA] (JBIDE-11482) AS7 / EAP6 not waiting properly for module to load (code cleanup)

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-11482.
---------------------------------

    Resolution: Done


Hey Martin! :D

In this specific piece of jira, the general use case is run on -> run on server   for an index.html, jsp, servlet, etc.  The web browser would only open once it knew the module was deployed. If the module wasn't finished deploying, it would wait, and ask over and over again, once every few seconds. 

This is to prevent 404's where the module is copied over, but the web browser opens too fast. 

This specific jira is about me moving some code around so that each server type provides an interface to 'poll' the server and see if the module is ready, rather than having the code all in one place with lots of if( version == 6 ) blah blah. 

To test it, you'll want to create an as5 server, a web project, a servlet, and run the servlet on the server, and make sure the web browser opens at the right time. Repeat for as6, as7, eap6, blah blah. 

If the browser opens too early, and gets a 404, that's a bug. If the web browser NEVER opens, it is probably polling over and over again in the background, and that is also a bug. 
                
> AS7 / EAP6 not waiting properly for module to load (code cleanup)
> -----------------------------------------------------------------
>
>                 Key: JBIDE-11482
>                 URL: https://issues.jboss.org/browse/JBIDE-11482
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers, jmx
>    Affects Versions: 3.3.0.Beta3
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 3.3.0.CR1
>
>
> Mixing management code and jmx code in the JBTWebLaunchableClient is not smart coding practice.  The remove module state verification should be received somehow through the new extended properties api, through a verifier of some type. 
> Also, some constant types for jmx should be renamed. Using server versions is not appropriate,  but rather, types are more reasonable. jmx over jndi, jmx over management, etc.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira