[jbosstools-issues] [JBoss JIRA] (JBIDE-11738) Solve/workaround the issue of needing endorsed libraries on Java 6

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12691207#comment-12691207 ] 

Max Rydahl Andersen commented on JBIDE-11738:
---------------------------------------------

Looks good, a few comments:

> It parses <compilerArgument> for -Djava.endorsed.dirs=([^ \\t]+) and falls back on the <compilerArguments><endorseddirs> value.

Shouldn't it be the other way around ? endorseddirs first, compilerargument second ? or is that because <compilerArgument> actuallly can override the endorsed dirs ?

With respect to the regular expression I guess this could be problematic if the directory have spaces in it? 
(could be a future enhancement to handle that - and I guess endorseddirs would be able to handle spaces?)

> maybe trigger dependency:copy, as Max suggested, if the endorsed dirs don't exist already (but I'm not super fan of that solution)

Any alternatives to this ? (besides hoping users will guess and figure it out on their own to run a mvn build first?)

                
> Solve/workaround the issue of needing endorsed libraries on Java 6
> ------------------------------------------------------------------
>
>                 Key: JBIDE-11738
>                 URL: https://issues.jboss.org/browse/JBIDE-11738
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers, maven
>            Reporter: Max Rydahl Andersen
>            Assignee: Fred Bricon
>            Priority: Critical
>             Fix For: 3.3.0.CR1
>
>
> JAX-WS has non-backwards compatible API changes requiring you to put specific jars on to endorsed libraries.
> Could we write a configurator that reacts to common ways of working around it in eclipse.
> m2e issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=363237
> Related to JBIDE-11348

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira