[jbosstools-issues] [JBoss JIRA] (JBIDE-11777) OpenShift wizard: Embedding jenkins clears 'type' and 'gear' fields

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12691485#comment-12691485 ] 

Andre Dietisheim edited comment on JBIDE-11777 at 5/9/12 12:00 PM:
-------------------------------------------------------------------

the reason is an update to the targets- and models- (observables) of the wizard page. The one that we always do when running jobs in the wizard:

WizardUtils:
{code}
public static IStatus runInWizard(Job job, DelegatingProgressMonitor monitor, IWizardContainer container, DataBindingContext dbc) 
	throws InvocationTargetException, InterruptedException {
	IStatus status = runInWizard(job, monitor, container);
	dbc.updateTargets();
	dbc.updateModels();
	return status;
}
{code}

The dbc.updateTargets is actually resetting the selected cartridge in the wizard page model (sets this model property to null). Digging for the exact reason, I found myself in SWT library. If this was confirmed, that would mean that every wizard page that uses databinding and runs jobs would have its 
comboboxes resetted. For now there's no need to dig deeper into this since we just have the time to polish our CR1. Using the WizardUtils#runInWizard solves this issue for me since no updates are triggered.

@Xavier: please verify that your issue is not present either.
                
      was (Author: adietish):
    the reason is an update to the targets- and models- (observables) of the wizard page. The one that we always do when running jobs in the wizard:

WizardUtils:
{code}
public static IStatus runInWizard(Job job, DelegatingProgressMonitor monitor, IWizardContainer container, DataBindingContext dbc) 
	throws InvocationTargetException, InterruptedException {
	IStatus status = runInWizard(job, monitor, container);
	dbc.updateTargets();
	dbc.updateModels();
	return status;
}
{code}

The dbc.updateTargets is actually setting null to selected cartridge in the wizard page model. Using the WizardUtils#runInWizard solves this issue since no update is executed.

@Xavier: please verify that your issue is not present either.
                  
> OpenShift wizard: Embedding jenkins clears 'type' and 'gear' fields
> -------------------------------------------------------------------
>
>                 Key: JBIDE-11777
>                 URL: https://issues.jboss.org/browse/JBIDE-11777
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 3.3.0.Beta3
>            Reporter: Stefan Bunciak
>            Assignee: Xavier Coulon
>             Fix For: 3.3.0.CR1
>
>         Attachments: jenkins.png
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira