[jbosstools-issues] [JBoss JIRA] (JBIDE-11714) Replace requirements folder & requirements bootstrap job by "self-hosted" content in pom.xml ?

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693231#comment-12693231 ] 

Mickael Istria commented on JBIDE-11714:
----------------------------------------

Very good questions! I just gave a try and here are some good answers.

> this new approach will require much more diskspace if you are running all tests
That's true. We could then think about using another location for the output, and make it configurable through a property (as it is with the former approach).
Are there cases where we run all SWTBot tests?

# maven-dependency-plugin uses markers to not perform on a place where is just performed: if no change happened in M2_REPO between 2 invocations of this plugin, it keeps what it did in first run. Then the second execution does nothing except telling the dependency is already here
# You download only once, whether you are offline or not: Maven repo acts as a cache. If you run "mvn clean install" they you get a new "unpack". If we unpack in another folder (not in target/) then "clean" won't remove it, and we keep it forever. Currently "mvn clean install" ensures you have a clean server, "mvn install" keeps the previous one. It should be OK for everybody
# So I tried a "mvn -o install", here is what I got:
{code}
NFO] --- maven-dependency-plugin:2.4:unpack (unpack) @ org.jboss.tools.jsf.ui.bot.test ---
[INFO] Configured Artifact: org.jboss.as:jboss-as-dist:7.0.2.Final:zip
> isMarkerOlder:
  artifact1 = /home/mistria/.m2/repository/org/jboss/as/jboss-as-dist/7.0.2.Final/jboss-as-dist-7.0.2.Final.zip
  marker    = /home/mistria/workspaceJBossTools/jboss-tools-eclipse-repository/jsf/tests/org.jboss.tools.jsf.ui.bot.test/target/dependency-maven-plugin-markers/org.jboss.as-jboss-as-dist-zip-7.0.2.Final.marker
    artifact1 lastModified: 1337159586000
    marker lastModified: 1337159586000
< false = marker older than artifact?
[INFO] Configured Artifact: org.richfaces:richfaces-distribution:4.2.1.Final:zip
> isMarkerOlder:
  artifact1 = /home/mistria/.m2/repository/org/richfaces/richfaces-distribution/4.2.1.Final/richfaces-distribution-4.2.1.Final.zip
  marker    = /home/mistria/workspaceJBossTools/jboss-tools-eclipse-repository/jsf/tests/org.jboss.tools.jsf.ui.bot.test/target/dependency-maven-plugin-markers/org.richfaces-richfaces-distribution-zip-4.2.1.Final.marker
    artifact1 lastModified: 1337159780000
    marker lastModified: 1337159780000
< false = marker older than artifact?
[INFO] jboss-as-dist-7.0.2.Final.zip already unpacked.
[INFO] richfaces-distribution-4.2.1.Final.zip already unpacked.
{code}
As you can see:
# When you have the dependency in your M2_REPO, you can work offline and maven-dependency-plugin behaves well
# When you do not clean, you keep the previous install

I admit I did not expected the plugin to behave so well!
                
> Replace requirements folder & requirements bootstrap job by "self-hosted" content in pom.xml ?
> ----------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-11714
>                 URL: https://issues.jboss.org/browse/JBIDE-11714
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>    Affects Versions: 3.3.0.Beta3
>            Reporter: Mickael Istria
>            Assignee: Mickael Istria
>            Priority: Minor
>             Fix For: 3.3.0.CR1
>
>         Attachments: JBIDE-11714-ws-sample.patch
>
>
> Currently, jobs depdend on the requirement folder to perform tests (requirement contains scripts aimed to retrieving runtimes for tests). Instead, we should think about creating a Maven Mojo or something more convenient so that test pom.xml could directly contain their setup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira