[jbosstools-issues] [JBoss JIRA] (JBDS-2153) Do not embed/wrap 3rd-party bundles in our sources

[Mickael Istria (JIRA)]

     [ https://issues.jboss.org/browse/JBDS-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mickael Istria updated JBDS-2153:
---------------------------------

    Attachment: JBDS-2153-step1.png
                JBDS-2153-step2.png
                JBDS-2153-step3.png


I have a patch (too big to be attached) that replace wrapping of findbugs and pmd bundles by consumption of the features from the requirements site.
Build and installation perform well, here are screenshots of how UI looks like when trying to install them:

!JBDS-2153-step1.png! => !JBDS-2153-step2.png! => !JBDS-2153-step3.png!

Is it OK, can I commit it?


Be aware that this is currently only relevant for bundles that were wrapped because of issue in plugin & feature name being the same (which is no more true with Tycho 0.14 according to my local tests and installation).
Then I removed the wrapped bundles and used <requires><import feature="..."/></requires> in our features and added the "official" feature uncategorized on the generated site.

This does not yet apply to springsource bundle, that was overriden because of its intrusion in welcome screen. We'll need to verify if the JBDS welcome screen is still affected before removing it.
                
> Do not embed/wrap 3rd-party bundles in our sources
> --------------------------------------------------
>
>                 Key: JBDS-2153
>                 URL: https://issues.jboss.org/browse/JBDS-2153
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 5.0.0.Beta3
>            Reporter: Mickael Istria
>            Assignee: Mickael Istria
>             Fix For: 6.x
>
>         Attachments: JBDS-2153-step1.png, JBDS-2153-step2.png, JBDS-2153-step3.png
>
>
> in devstudio/extras, we can see that we define some "wrapper" bundles for 3rd party deps (findbugs, pmd, spring...). This is not the most straightforward approach, and it seems like we could improve it. Here are some reasons that would have justified this implementation, and some reasons why we can improve it:
> > a) the plugin and feature have the same IU name and therefore confuse Tycho 
> How is this possible? p2 adds .feature.group to features. We should think about a 3rd-party feature that requires either this plugins or features, that we could provide in the extras site.
> > b) the plugin contributes to the welcome screen and breaks JBDS, so we override that 
> According to Max, this is no more the case.
> > c) because the license doc is incomplete so we provide a more explicit/accurate license by wrapping it w/ our own feature 
> We can use our feature and add this bundle as required, so we use their bundles and they are installed from our feature. Using required allows people to perform updates from the other sites by themselves.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira